Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove json transaction unmarshaling support for celo transactions legacy transactions retrieved from a celo node. #237

Open
piersy opened this issue Sep 24, 2024 · 0 comments
Labels
type:enhancement New feature or request

Comments

@piersy
Copy link

piersy commented Sep 24, 2024

We should do this some time after we have migrated all celo chains to be L2s.

In celo_transaction_marshaling.go the function celoTransactionUnmarshal has the following code, we simply need to replace if dec.EthCompatible == nil || *dec.EthCompatible == true { with if dec.EthCompatible == nil {

func celoTransactionUnmarshal(dec txJSON, inner *TxData) (bool, error) {
	switch dec.Type {
	case LegacyTxType:
		// EthCompatible is only set to false for celo legacy transactions in the op-geth codebase, otherwise its not
		// set. So not set means it is ethCompatible. However in order to support correct unmarshaling of a celo legacy
		// transaction, retrieved from a celo node (for the purposes of running our api compatibility test) we also need to
		// handle the case where EthCompatible is set to true. 
		if dec.EthCompatible == nil || *dec.EthCompatible == true {
			return false, nil
		}
@piersy piersy added the type:enhancement New feature or request label Sep 24, 2024
@lvpeschke lvpeschke added this to the 6 - Post MVP Mainnet milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants