Handle migrated celo transactions #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we will be supporting decoding and encoding all old celo tx types in op-geth we may as well use the same naming.
This means most of the existing codebase should work now
This adds the structure and rlp encode/decode functionality but no signing or json marshaling logic because for syncing it may not be required.
palango
reviewed
Jun 21, 2024
| GasPrice *big.Int // wei per gas | ||
| Gas uint64 // gas limit | ||
|
|
||
| // Celo-specific fields |
There was a problem hiding this comment.
Any specific reason why you put this between the ethereum fields?
piersy
commented
Jun 21, 2024
|
Oh, and please create a follow-up issue to add some tests. |
Added issue here - #151 |
palango
approved these changes
Jun 21, 2024
karlb
pushed a commit
that referenced
this pull request
Jul 10, 2024
Introduces support for encoding/decoding legacy celo transaction types. That covers: Type 0 - The legacy transaction has been updated and now has the celo specific fields added Type 124 - The v1 of the dynamic fee tx. Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface. Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.
karlb
pushed a commit
that referenced
this pull request
Jul 10, 2024
Introduces support for encoding/decoding legacy celo transaction types. That covers: Type 0 - The legacy transaction has been updated and now has the celo specific fields added Type 124 - The v1 of the dynamic fee tx. Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface. Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.
karlb
pushed a commit
that referenced
this pull request
Jul 12, 2024
Introduces support for encoding/decoding legacy celo transaction types. That covers: Type 0 - The legacy transaction has been updated and now has the celo specific fields added Type 124 - The v1 of the dynamic fee tx. Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface. Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.
karlb
pushed a commit
that referenced
this pull request
Aug 20, 2024
Introduces support for encoding/decoding legacy celo transaction types. That covers: Type 0 - The legacy transaction has been updated and now has the celo specific fields added Type 124 - The v1 of the dynamic fee tx. Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface. Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.
karlb
pushed a commit
that referenced
this pull request
Aug 26, 2024
Introduces support for encoding/decoding legacy celo transaction types. That covers: Type 0 - The legacy transaction has been updated and now has the celo specific fields added Type 124 - The v1 of the dynamic fee tx. Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface. Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.
karlb
pushed a commit
that referenced
this pull request
Aug 30, 2024
Introduces support for encoding/decoding legacy celo transaction types. That covers: Type 0 - The legacy transaction has been updated and now has the celo specific fields added Type 124 - The v1 of the dynamic fee tx. Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface. Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.
karlb
pushed a commit
that referenced
this pull request
Oct 11, 2024
Introduces support for encoding/decoding legacy celo transaction types. That covers: Type 0 - The legacy transaction has been updated and now has the celo specific fields added Type 124 - The v1 of the dynamic fee tx. Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface. Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.
piersy
added a commit
that referenced
this pull request
Oct 15, 2024
Introduces support for encoding/decoding legacy celo transaction types. That covers: Type 0 - The legacy transaction has been updated and now has the celo specific fields added Type 124 - The v1 of the dynamic fee tx. Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface. Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces support for encoding/decoding legacy celo transaction types.
That covers:
Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the
TxDatainterface.Additionally I reversed the
EthCompatibleboolean field since it's used to determine how to encode a legacy tx, and if unset (I.E.EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is calledCeloLegacyand if unset the tx will be encoded as an eth compatible transaction.