Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watcher: Refactor ConnectionManager config #895

Open
yourbuddyconner opened this issue Oct 13, 2021 · 0 comments
Open

watcher: Refactor ConnectionManager config #895

yourbuddyconner opened this issue Oct 13, 2021 · 0 comments
Assignees
Labels
agents Relating to rust agents refactor redesign or restructure rust 🦀 Rust dev work required

Comments

@yourbuddyconner
Copy link
Contributor

Right now the connectionManagers config in the watcher-partial.json looks like this:

"connectionManagers": [
    {
      "address": "0x0000000000000000000000000000000000000000",
      "domain": "60",
      "name": "ethereum",
      "rpcStyle": "ethereum",
      "config": {
        "connection": {
          "type": "ws",
          "url": "ws://localhost:8545"
        }
      }
    },
    {
      "address": "0x0000000000000000000000000000000000000000",
      "domain": "61",
      "name": "eth-classic",
      "rpcStyle": "ethereum",
      "config": {
        "connection": {
          "type": "ws",
          "url": "ws://localhost:8545"
        }
      }
    }
  ]

This is problematic because it's not possible to set sub-keys of these configs via Environment Variable. As such we need to refactor this config to be a map, probably something like this:

"connectionManagers": {
    "BridgeRouter": {
      "address": "0x0000000000000000000000000000000000000000",
      "network": "kovan",
      "name": "BridgeRouter"
    },
    "BridgeRouter": {
      "address": "0x0000000000000000000000000000000000000000",
      "network": "rinkeby",
      "name": "BridgeRouter"
    },
    "BridgeRouter": {
      "address": "0x0000000000000000000000000000000000000000",
      "network": "rinkeby",
      "name": "BridgeRouter"
    }
  }
@luketchang luketchang self-assigned this Oct 13, 2021
@luketchang luketchang added agents Relating to rust agents refactor redesign or restructure rust 🦀 Rust dev work required labels Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents Relating to rust agents refactor redesign or restructure rust 🦀 Rust dev work required
Projects
None yet
2 participants