You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The benefit I see here is that some dapps might decide their target audience doesn't need Ledger for instance. Or if they do the app could load that async and thus breakup app bundle into separate parts which could help with initial loading time
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
This is very much in the is this worth idea phase, not planning on implementing for next version
Currently all connectors and their dependencies are loaded.
Some of these such as Ledger Connector depend on libraries that are not small.
While internally these packages are loading with async import they are still part of the same JS bundle (when bundle react-celo with next.js).
Proposal
A system where Connectors and their modal Screen were packaged up in an object and array of them could be passed as a prop to CeloProvider.
The benefit I see here is that some dapps might decide their target audience doesn't need Ledger for instance. Or if they do the app could load that async and thus breakup app bundle into separate parts which could help with initial loading time
Beta Was this translation helpful? Give feedback.
All reactions