Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update login view when user name or password wrong #15

Open
letlet opened this issue Apr 8, 2017 · 4 comments
Open

How to update login view when user name or password wrong #15

letlet opened this issue Apr 8, 2017 · 4 comments

Comments

@letlet
Copy link

letlet commented Apr 8, 2017

I want to tell the user name or password is wrong when there is something wrong with the user's input by update login view

@initFabian
Copy link
Collaborator

Hey @letlet,

Thanks for the issue, this is a great suggestion!

The thing about this topic is that this trends the borders of just creating a custom LoginViewController. Before just classifying as a custom LoginVC need, can you give me some more details... Would a simple AlertViewController popup work?

@letlet
Copy link
Author

letlet commented Apr 30, 2017

Yes, a AlertViewController popup works and is the solution I'm using. But it's not elegant. Error message above the input area is more usefull.

@initFabian
Copy link
Collaborator

Im still very open to this feature request.

If someone doesn't mind, open up a PR that passes the following criteria:

  • A single error message appearing onto of the Username textfield
  • Add styling option in CelyStyle to change Font of styling, but have a default implementation inside of CelyStyle extension.
  • Update Documentation and affected tests

@rlam3
Copy link
Collaborator

rlam3 commented Oct 25, 2017

@letlet did you find a workaround for this? I'm running into a similar situation with cely...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants