Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accidental rendering #6

Open
vinnyt opened this issue Dec 27, 2018 · 1 comment
Open

accidental rendering #6

vinnyt opened this issue Dec 27, 2018 · 1 comment

Comments

@vinnyt
Copy link

vinnyt commented Dec 27, 2018

I am trying to figure out how to make the rendering of the notes a little more intelligent. There are situations where multiple instances of the same note show in the circle so. Think G major, G A B C D E F#, in the view however it shows as G A B C D E Gb, while technically correct when talking about G major, for example, it is a little weird to think of the scale in terms of "G A B C D E Gb".

I thought the variable preferredAccidentIsFlats would impact this behavior, but changing it has no impact on what is rendered in the view, any other ideas?

@vinnyt
Copy link
Author

vinnyt commented Jan 22, 2019

@cemolcay any thoughts on this one, if you can point me at where to look in the code, I would be happy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant