Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSK Processing #299

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

DSK Processing #299

wants to merge 20 commits into from

Conversation

kris927b
Copy link
Collaborator

Adding a generic script for processing DSK data.

The script can so far handle:

  • Docx
  • PDF
  • EPUB
  • HTML
  • TXT

@kris927b kris927b requested a review from rlrs October 25, 2024 12:25
@kris927b kris927b enabled auto-merge November 8, 2024 14:17
@kris927b kris927b marked this pull request as draft November 14, 2024 13:45
auto-merge was automatically disabled November 14, 2024 13:45

Pull request was converted to draft

@kris927b kris927b marked this pull request as ready for review November 19, 2024 10:19
@kris927b kris927b requested a review from saattrupdan November 20, 2024 07:54
saattrupdan
saattrupdan requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@saattrupdan saattrupdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few initial comments.

I can't recall if we've decided on a level of code quality. I would personally like to see docstrings everywhere, including module docstrings, as well as unit tests. But you all think that's a bit too much then disregard that.

data-processing/scripts/dsk/convert_dsk_to_jsonl.py Outdated Show resolved Hide resolved
data-processing/scripts/dsk/convert_dsk_to_jsonl.py Outdated Show resolved Hide resolved
data-processing/scripts/dsk/utils.py Outdated Show resolved Hide resolved
data-processing/scripts/dsk/README.md Outdated Show resolved Hide resolved
data-processing/scripts/dsk/convert_dsk_to_jsonl.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlrs rlrs Awaiting requested review from rlrs

@saattrupdan saattrupdan Awaiting requested review from saattrupdan

@KennethEnevoldsen KennethEnevoldsen Awaiting requested review from KennethEnevoldsen

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
data-cleaning dataset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kris927b @KennethEnevoldsen @saattrupdan