-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batching #42
base: master
Are you sure you want to change the base?
Batching #42
Conversation
@vanelizarov Hello! I have some questions to this pr:
Subscription batching is a good feature – but I can't start reviewing this in current pr form - it's too heavy and has non-obvious changes. In general it's better to decouple different things to different pull requests. But before doing this let's elaborate more on my point 1 above. |
@FZambia about #31 and your discussion with @synw, IMHO the only reason to have awaitable About tests, I've started rewriting them but at some point, I got stuck and put this activity on the back burner. I can push the changes, so you can review them in the current state. It would be also great if you tell me if I am doing it the right way or not. About decoupling, I was thinking about it during the process but all in all, figured out that it would be more correct to suggest this feature as one PR because all its parts are tightly connected to each other. As I mentioned above, mostly it repeats the logic from the web library but adjusted for Dart language specificity, and the structure of this library. Also, I can provide some explanations if needed |
Is this still considered to be merged at some point? |
@SimonHausdorf hello, this pr was too heavy and contained some non-obvious changes, so I have not looked closely. If you are interested in having batching (are you? or you need sth else from this pr?) then better to start from discussing a use case and make a minimal improvement that will help your use case. |
Added batching and private channels subscribe batching like in js version of the lib
At the same time fixed Make all async functions return a Future #31