From aa5fa7108d7d868bb5ed1b1065c50c6f137a6186 Mon Sep 17 00:00:00 2001 From: katty barroso Date: Fri, 15 Nov 2024 09:34:52 +0100 Subject: [PATCH 1/3] Fix links --- centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx b/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx index e9a0376013..544d01909b 100644 --- a/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx +++ b/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx @@ -287,7 +287,7 @@ const AvailableNetworks = ({ poolId }: { poolId: string }) => { const renderTooltipBody = (networkName: string, tranches: Tranche[], baseUrl: string) => { const links = tranches.map((tranche) => ({ text: `View Transactions`, - url: `${baseUrl}/token/${tranche.id}`, + url: baseUrl, })) return From b1cf50839b9fa64e27fa4eea0035f156cc85fc95 Mon Sep 17 00:00:00 2001 From: katty barroso Date: Tue, 19 Nov 2024 12:38:49 +0100 Subject: [PATCH 2/3] Fix links with token address --- .../src/components/PoolOverview/KeyMetrics.tsx | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx b/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx index 544d01909b..069223ddc3 100644 --- a/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx +++ b/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx @@ -285,10 +285,15 @@ const AvailableNetworks = ({ poolId }: { poolId: string }) => { const pool = usePool(poolId) const renderTooltipBody = (networkName: string, tranches: Tranche[], baseUrl: string) => { - const links = tranches.map((tranche) => ({ - text: `View Transactions`, - url: baseUrl, - })) + const links = tranches.map((tranche, index) => { + const tokenAddress = activeDomains?.data?.find((domain) => domain.trancheTokens[tranche.id])?.trancheTokens[ + tranche.id + ] + return { + text: `View Transactions`, + url: `${baseUrl}token/${tokenAddress}`, + } + }) return } From 5c7a094d8ad87716aab81bde8773a4597e12ecae Mon Sep 17 00:00:00 2001 From: katty barroso Date: Tue, 19 Nov 2024 12:45:59 +0100 Subject: [PATCH 3/3] Add feedback --- .../src/components/PoolOverview/KeyMetrics.tsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx b/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx index 069223ddc3..107302352f 100644 --- a/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx +++ b/centrifuge-app/src/components/PoolOverview/KeyMetrics.tsx @@ -285,15 +285,15 @@ const AvailableNetworks = ({ poolId }: { poolId: string }) => { const pool = usePool(poolId) const renderTooltipBody = (networkName: string, tranches: Tranche[], baseUrl: string) => { - const links = tranches.map((tranche, index) => { - const tokenAddress = activeDomains?.data?.find((domain) => domain.trancheTokens[tranche.id])?.trancheTokens[ - tranche.id - ] - return { + const links = tranches + .map( + (tranche) => activeDomains?.data?.find((domain) => domain.trancheTokens[tranche.id])?.trancheTokens[tranche.id] + ) + .filter(Boolean) + .map((tokenAddress) => ({ text: `View Transactions`, url: `${baseUrl}token/${tokenAddress}`, - } - }) + })) return }