Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: development of DetCRD (CEPC Reference Detector) #28

Open
1 of 3 tasks
mirguest opened this issue Sep 15, 2020 · 5 comments
Open
1 of 3 tasks

WIP: development of DetCRD (CEPC Reference Detector) #28

mirguest opened this issue Sep 15, 2020 · 5 comments
Milestone

Comments

@mirguest
Copy link
Member

mirguest commented Sep 15, 2020

@mirguest mirguest added this to the v0.1 milestone Sep 15, 2020
@mirguest
Copy link
Member Author

Hi @LinghuiWuIHEP,

could you create a new issue to track the development status of the calorimeter detector?

Thanks.
Tao

@mirguest mirguest modified the milestones: v0.1, v0.2 Sep 17, 2020
@fucd
Copy link
Contributor

fucd commented Sep 18, 2020

Hi @mirguest and all,

I try to implement base compact files and beampipe as begin of CRD, see PR #44.
In this implement, set a main version ix (i denotes coil inside Hcal, and o will denote coil outside Hcal in future) and a branch version to make up whole detector, like ILD. But many links in ILD are removed to make the parameters more clear.

If any comments or suggestion about it, please let me know.

Chengdong

@mirguest
Copy link
Member Author

Hi @mirguest and all,

I try to implement base compact files and beampipe as begin of CRD, see PR #44.
In this implement, set a main version ix (i denotes coil inside Hcal, and o will denote coil outside Hcal in future) and a branch version to make up whole detector, like ILD. But many links in ILD are removed to make the parameters more clear.

If any comments or suggestion about it, please let me know.

Chengdong

Hi @fucd,
First, thanks for your work.

I think it's better to follow a naming convention for the different detector options.

In lcgeo, I think their convention is option + version (such as CLIC_o3_v05) in CLIC.
The ILD also provides an example to describe their detector options (such as ILD_l5_o1_v02) in their README.

So the meaning of o is actually option. I would suggest to avoid such confusion when you name the detectors.

Tao

@mirguest mirguest pinned this issue Sep 19, 2020
@fucd
Copy link
Contributor

fucd commented Sep 19, 2020

Hi @mirguest and all,
I try to implement base compact files and beampipe as begin of CRD, see PR #44.
In this implement, set a main version ix (i denotes coil inside Hcal, and o will denote coil outside Hcal in future) and a branch version to make up whole detector, like ILD. But many links in ILD are removed to make the parameters more clear.
If any comments or suggestion about it, please let me know.
Chengdong

Hi @fucd,
First, thanks for your work.

I think it's better to follow a naming convention for the different detector options.

In lcgeo, I think their convention is option + version (such as CLIC_o3_v05) in CLIC.
The ILD also provides an example to describe their detector options (such as ILD_l5_o1_v02) in their README.

So the meaning of o is actually option. I would suggest to avoid such confusion when you name the detectors.

Tao

Hi @mirguest

Thanks for your comments. The option versions are divided as simulation and reconstruction. In ILD, as my understood, ILD_l5_v02 denotes simulation option, and then it will extension to several reconstruction-relative options (such as ILD_l5_o1_v02). Currently, CRD_i1_v01
is simulation-based version. It has also described in Detector/DetCRD/compact/README.md, and will be extended continuously.

Chengdong

@fucd
Copy link
Contributor

fucd commented Dec 2, 2020

According to version name rule, cancel #44, now apply PR #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants