Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating java openjdk to version 17 on rhel and debian builders #2293

Closed
wants to merge 2 commits into from

Conversation

akraitman
Copy link
Contributor

Updating java openjdk to version 17 on rhel and debian builders, I have added the update-alternatives command to make sure we set the OS to use the correct java version

@akraitman akraitman force-pushed the wip-update-java-alternantives branch from ec4773a to 2ca6d5a Compare November 20, 2024 13:14
@akraitman akraitman requested a review from djgalloway November 21, 2024 13:34
Copy link
Contributor

@djgalloway djgalloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tested on both distros? And we have an Ubuntu and a Red Hat Jenkins builder running jobs successfully after having this change applied?

@akraitman
Copy link
Contributor Author

This is tested on both distros? And we have an Ubuntu and a Red Hat Jenkins builder running jobs successfully after having this change applied?

Yes, It was ran against all of our upstream builders

@djgalloway
Copy link
Contributor

Resolve the merge conflict and I'll approve

@akraitman akraitman force-pushed the wip-update-java-alternantives branch from a5f883f to 18cf775 Compare January 29, 2025 09:37
@djgalloway
Copy link
Contributor

djgalloway commented Jan 30, 2025

Rebase back to 2ca6d5a and just remove the dashes in front of each var in builder.yml. I really don't want to merge a merge commit if we can avoid it.

Ping me if you want help going over this on a call.

@akraitman akraitman force-pushed the wip-update-java-alternantives branch 2 times, most recently from 5d98ff1 to 2ca6d5a Compare January 30, 2025 16:47
@akraitman akraitman force-pushed the wip-update-java-alternantives branch from 2ca6d5a to 0dc684d Compare January 30, 2025 16:56
@akraitman akraitman closed this Feb 2, 2025
@akraitman akraitman deleted the wip-update-java-alternantives branch February 2, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants