Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove decprecation warning from logs #119

Open
subhamkrai opened this issue Aug 14, 2024 · 11 comments · May be fixed by #154
Open

remove decprecation warning from logs #119

subhamkrai opened this issue Aug 14, 2024 · 11 comments · May be fixed by #154
Labels
good first issue Good for newcomers

Comments

@subhamkrai
Copy link
Contributor

operator logs start with the below warning in Rook CI, raising the issue for awarness

W0814 04:10:28.248745       1 options.go:164] 
==== Deprecation Warning ======================

Insecure listen address will be removed.
Using --insecure-listen-address won't be possible!

The ability to run kube-rbac-proxy without TLS certificates will be removed.
Not using --tls-cert-file and --tls-private-key-file won't be possible!

For more information, please go to https://github.com/brancz/kube-rbac-proxy/issues/187

===============================================

		
W0814 04:10:28.248863       1 options.go:215] 
==== Removed Flag Warning ======================

logtostderr is removed in the k8s upstream and has no effect any more.

===============================================
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 14, 2024

@subhamkrai can you please point me to the Rook job here?

@subhamkrai
Copy link
Contributor Author

@subhamkrai can you please point me to the Rook job here?

it will not be in the job, but it will be artifacts of the job. currently job is running I'll share the job.

@subhamkrai
Copy link
Contributor Author

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 14, 2024

@leelavg are you also seeing this error in operator logs?

@leelavg
Copy link
Contributor

leelavg commented Aug 14, 2024

well, I didn't look at kube-rbac-proxy container logs.

@nb-ohad
Copy link
Collaborator

nb-ohad commented Aug 15, 2024

@Madhu-1 @subhamkrai We will need to live with that deprecation warning for some time because we are targeting older k8s releases

@travisn
Copy link
Member

travisn commented Aug 15, 2024

What K8s version is needed to avoid that warning? Rook just updated the min version supported to v1.26. For running the CSI operator we could easily set the min supported version to v1.27, since that will be our min version for the next Rook release v1.16 where csi operator will no longer be experimental.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 15, 2024

It doesn't look like kubernetes version problem but it's like container image problem, let me check this and see what is the exact problem

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 16, 2024

This is not related to kubernetes version, its related to kube-proxy brancz/kube-rbac-proxy#187

@Madhu-1 Madhu-1 added the good first issue Good for newcomers label Sep 18, 2024
@leelavg
Copy link
Contributor

leelavg commented Oct 4, 2024

Looked into this for a bit and here are my thoughts

kube-rbac-proxy now wants tls cert & private key file, for d/s there are 2 solutions, https://docs.openshift.com/container-platform/4.17/security/certificates/service-serving-certificate.html or https://github.com/openshift/service-ca-operator but for u/s we need user to deploy https://cert-manager.io/docs/installation/helm/ or provide certificates manually.

however, iirc this dependency is being added by kubebuilder w/ the assumption that non-resource urls (for ex: metrics) also need authentication but csi-op doesn't export any metrics and this dep could be dropped altogether.

if we infact choose to continue, I don't see the seriousness in continuing to use the proxy w/o certs.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 4, 2024

If not required, lets drop the container from the deployment. Lets discuss in the team meeting

@leelavg leelavg linked a pull request Oct 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants