Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBD image namespace resize doesn't reflect across cluster nodes for nvme subsystem #712

Closed
skbeura opened this issue Jun 11, 2024 · 8 comments
Assignees

Comments

@skbeura
Copy link

skbeura commented Jun 11, 2024

Have expanded a nvme namespace successfully on a 3-node ceph cluster. The new size was showing only on Node-01 and shows old size for other nodes while listing.
If I expand the RBD image and same doesn't reflect on the nvme namespace. Is it not supported to reflect for the namespace? Pls let me know. Thanks.

Ceph Version: ceph version 18.2.2 (531c0d11a1c5d39fbfe6aa8a521f023abf3bf3e2) reef (stable)
Host OS: Oracle Linux Server release 8.9
nvmeof & nvmeof-cli: v1.0.0
Protocol: NVMe over TCP

Initiator: VMware ESXi, 7.0.3

attached file for reference.
nvme namespace resize issue.docx

@skbeura skbeura changed the title RBD image namespace resize doesn't reflect across all Nodes under one nvme subsystem RBD image namespace resize doesn't reflect across cluster nodes for nvme subsystem Jun 11, 2024
@gbregman
Copy link
Contributor

This seems like an SPDK issue. When an image is resized on a different node, SPDK doesn't update the size information for that image. So, when we read this info from the local SPDK we get old information. We can try replacing the usage of SPDK with RBD calls, to get the size.

@skbeura
Copy link
Author

skbeura commented Jun 19, 2024

There is another issue that SPDK doesn't report the extended size normally where as RBD reports it correct. Below is one of the example where SPDK reports the new extended size for the nvme-image01 as 1.5PiB and RBD displays it correctly as 1.5TiB.

image

@gbregman
Copy link
Contributor

@skbeura , this issue was already fixed, see here

@gbregman
Copy link
Contributor

@gbregman
Copy link
Contributor

@skbeura I tested the resize in several scenarios and it seems to work. Notice that there is also a bz issue for this problem and @rahullepakshi should test it using the latest version. Please see if this issue can be closed.

@skbeura
Copy link
Author

skbeura commented Sep 4, 2024

@gbregman this can be closed as same issue already reported @bz. May I know which nvmeof gw version you tried, so that I will validate. Thank you.

@gbregman
Copy link
Contributor

gbregman commented Sep 4, 2024

@skbeura this should work on any gw version. Only we realized that this only works when enlarging the image size. If the image size is shrunk, SPDK wouldn't update its internal image size and then a "namespace list" command would show the old size. We need to ask the SPDK people if there was a reason for that. As it is now, SPDK wouldn't allow you to resize a namespace to a smaller size and in case you've done it directly in RBD it would ignore this change.

@gbregman
Copy link
Contributor

gbregman commented Sep 4, 2024

We haze a bz issue for that so we can close this one.

@gbregman gbregman closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants