fix: add tests and log when there is an error when persisting anchors #1202
Conversation
| const ipfsProofCid = await ipfsService.storeRecord({}) | ||
| const anchors = await anchorService._createAnchorCommits(ipfsProofCid, merkleTree) | ||
|
|
||
| await Promise.all([ |
There was a problem hiding this comment.
I guess we're relying on a race condition here to sometimes trigger the serialization error we are catching and retrying on? I would prefer if we inject the failure explicitly so it's deterministic, but also don't feel super strongly. Can we at least add a comment explaining what we're doing here and why?
There was a problem hiding this comment.
made the test more deterministic and added comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1202 +/- ##
===========================================
+ Coverage 80.61% 80.89% +0.28%
===========================================
Files 47 47
Lines 1836 1837 +1
Branches 309 293 -16
===========================================
+ Hits 1480 1486 +6
+ Misses 356 351 -5 ☔ View full report in Codecov by Sentry. |
i forgot the test when creating the fix (#1201)