davix upgrade fails on MacOs Mojave

[andreaceccanti]

Hi,

davix upgrade fails from 0.6.9 to 0.7.2 on my mac:

10:56 $ brew upgrade davix
==> Upgrading 1 outdated package:
cern-fts/dmc/davix 0.6.9-1 -> 0.7.2-1
==> Upgrading cern-fts/dmc/davix
==> Cloning https://github.com/cern-fts/davix.git
Updating /Users/cecco/Library/Caches/Homebrew/davix--git
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
HEAD is now at c8063b7 RELEASE: 0.7.3
Entering 'deps/googletest'
/Users/cecco/Library/Caches/Homebrew/davix--git/deps/googletest
==> cmake -DENABLE_THIRD_PARTY_COPY=ON . -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/davix/0.7.2-1 -DCMAKE_BUILD_TYPE=Release -DCMAKE_FIND_FRAM
Last 15 lines from /Users/cecco/Library/Logs/Homebrew/davix/01.cmake:
-- Found gsoap: /usr/local/lib/libgsoap.a
-- Using gsoapssl flags -DWITH_OPENSSL;-DWITH_GZIP;-DWITH_DOM;-I/usr/local/Cellar/gsoap/2.8.89/include
CMake Error at src/modules/copy/CMakeLists.txt:64 (SET_TARGET_PROPERTIES):
  SET_TARGET_PROPERTIES called with incorrect number of arguments.


-- generate pkgconfig file for davix_copy under /tmp/davix-20190827-8981-19n4jwo/src/modules/copy/davix_copy.pc
CMake Error at src/CMakeLists.txt:40 (set_target_properties):
  set_target_properties called with incorrect number of arguments.


-- generate pkgconfig file for libdavix under /tmp/davix-20190827-8981-19n4jwo/src/davix.pc
-- Configuring incomplete, errors occurred!
See also "/tmp/davix-20190827-8981-19n4jwo/CMakeFiles/CMakeOutput.log".
See also "/tmp/davix-20190827-8981-19n4jwo/CMakeFiles/CMakeError.log".

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  https://github.com/cern-fts/homebrew-dmc/issues

[gbitzes]

Hi Andrea,

Thanks for the report, this issue has been found and fixed on master, I'll be making a new davix release tomorrow.

Cheers,
Georgios

[gbitzes]

Hi Andrea - it appears the issue has been fixed from 0.7.4 already, but homebrew has a broken 0.7.3 setup. I'll ask around on how to update it, will keep you posted.

[gbitzes]

Hi, here's the updated davix formula for the newest version, 0.7.5, let me know if it works.

I'll be submitting this to homebrew as well, but feel free to use in the meantime through brew edit.

class Davix < Formula
  desc "Library and tools for advanced file I/O with HTTP-based protocols"
  homepage "https://dmc.web.cern.ch/projects/davix/home"
  url "https://github.com/cern-fts/davix.git",
      :tag      => "R_0_7_5",
      :revision => "4b04a98027ff5ce94e18e3b110420f1ff912a32c"
  version "0.7.5"
  head "https://github.com/cern-fts/davix.git"

  bottle do
    cellar :any
    sha256 "85564894b2b7eb8f1896a815e1b3b9fe0bdcd1598060ec3872ec1fa0806f96d7" => :mojave
    sha256 "702eb13a7e16c4f73904f064bedce4a9e13a95d72b5428e5684ad3f5bb9566e9" => :high_sierra
    sha256 "324217f79b199881b1ea5967702d5deae7d3181d65c2162862345619534e9954" => :sierra
  end

  depends_on "cmake" => :build
  depends_on "doxygen" => :build
  depends_on "python@2" => :build
  depends_on "openssl"

  def install
    ENV.libcxx

    system "cp", "release.cmake", "version.cmake"
    system "mkdir", "build"
    system "cmake", "-S", ".", "-B", "build", *std_cmake_args
    system "make", "--directory", "build", "install"
  end

  test do
    system "#{bin}/davix-get", "https://www.google.com"
  end
end

[andrea-manzi]

Hey Giorgos
i think Andrea is using the formula hosted by us at https://github.com/cern-fts/homebrew-dmc/blob/master/davix.rb
cause the one on homebrew does not support tpc
i can merge your changes and do some tests to see if everything is fine
cheers
Andrea

[gbitzes]

Ah sure, thanks Andrea, go ahead.

You can use this updated version as a basis, the one that will likely end up in official homebrew: https://github.com/gbitzes/homebrew-core/blob/1f1f26b3e0ca139cb7bc4d8d7ae42dc95e44e67b/Formula/davix.rb

[andrea-manzi]

i have upgraded our formula and it worked fine for me when upgrading from 0.7.2 to 0.7.5
@andreaceccanti can you try now?

[andreaceccanti]

I tried again the clean upgrade from 0.6.9 to 0.7.5, and it fails on me:

17:01 $ brew upgrade davix
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 5 taps (homebrew/cask-versions, homebrew/core, homebrew/cask, homebrew/cask-fonts and cern-fts/dmc).
==> New Formulae
kubebuilder                                         now-cli                                             pdftk-java                                          pokerstove
==> Updated Formulae
cern-fts/dmc/davix ✔   azure-cli              dhall-bash             firebase-cli           hbase                  nomad                  rclone                 starship               webpack
gradle ✔               blueutil               diff-pdf               fn                     jenkins                opencv                 rmlint                 storm                  wskdeploy
node ✔                 cabal-install          efl                    frugal                 kafka                  parallel               rom-tools              subnetcalc             xmake
ruby-build ✔           cfn-lint               exploitdb              getdns                 kube-aws               pdftoipe               serverless             telegraf               zabbix
aliyun-cli             chronograf             fdroidserver           glooctl                kubecfg                poppler                sn0int                 trafficserver
aws-sdk-cpp            clingo                 ffsend                 goreleaser             lazydocker             pre-commit             srt                    vault-cli

==> Upgrading 1 outdated package:
cern-fts/dmc/davix 0.6.9-1 -> 0.7.5-1
==> Upgrading cern-fts/dmc/davix
==> Cloning https://github.com/cern-fts/davix.git
Updating /Users/cecco/Library/Caches/Homebrew/davix--git
From https://github.com/cern-fts/davix
   c8063b7..4b04a98  master     -> origin/master
==> Checking out branch master
Already on 'master'
Your branch is behind 'origin/master' by 49 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
HEAD is now at 4b04a98 RELEASE: 0.7.5
Entering 'deps/googletest'
/Users/cecco/Library/Caches/Homebrew/davix--git/deps/googletest
==> cmake -DENABLE_THIRD_PARTY_COPY=ON -S . -B build -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/davix/0.7.5-1 -DCMAKE_BUILD_TYPE=Release -DCMA
==> make --directory build install
Last 15 lines from /Users/cecco/Library/Logs/Homebrew/davix/02.make:
      Davix::XMLSAXParser::~XMLSAXParser() in davxmlparser.cpp.o
  "_ne_xml_get_error", referenced from:
      Davix::XMLSAXParser::parseChunk(char const*, unsigned long long) in davxmlparser.cpp.o
  "_ne_xml_parse", referenced from:
      Davix::XMLSAXParser::parseChunk(char const*, unsigned long long) in davxmlparser.cpp.o
  "_ne_xml_push_handler", referenced from:
      Davix::XMLSAXParser::XMLSAXParser() in davxmlparser.cpp.o
      Davix::XMLSAXParser::XMLSAXParser() in davxmlparser.cpp.o
  "_populate_cert", referenced from:
      Davix::SSL_X509_Pem_Read(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, Davix::DavixError**) in davix_openssl.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [src/libdavix.0.7.5.dylib] Error 1
make[1]: *** [src/CMakeFiles/libdavix.dir/all] Error 2
make: *** [all] Error 2

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  https://github.com/cern-fts/homebrew-dmc/issues

These open issues may also help:
davix upgrade fails on MacOs Mojave https://github.com/cern-fts/homebrew-dmc/issues/5

[andrea-manzi]

ah ok, my formula was still pointing to the master branch of davix and not to the specific tag. Should be fixed now, i just tried a 0.6.9 -> 0.7.5 upgrade and it worked fine

==> Upgrading 1 outdated package:
cern-fts/dmc/davix 0.6.9-1 -> 0.7.5
..
andreas-MacBook-Pro:~ andrea$ davix-cp --version
Version: 0.7.5

can you give it another try?

[andreaceccanti]

Unfortunately the upgrade failed in the same way:

==> Upgrading cern-fts/dmc/davix
==> Cloning https://github.com/cern-fts/davix.git
Updating /Users/cecco/Library/Caches/Homebrew/davix--git
==> Checking out tag R_0_7_5
HEAD is now at 4b04a98 RELEASE: 0.7.5
HEAD is now at 4b04a98 RELEASE: 0.7.5
Entering 'deps/googletest'
/Users/cecco/Library/Caches/Homebrew/davix--git/deps/googletest
==> cmake -DENABLE_THIRD_PARTY_COPY=ON -S . -B build -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX
==> make --directory build install
Last 15 lines from /Users/cecco/Library/Logs/Homebrew/davix/02.make:
      Davix::XMLSAXParser::~XMLSAXParser() in davxmlparser.cpp.o
  "_ne_xml_get_error", referenced from:
      Davix::XMLSAXParser::parseChunk(char const*, unsigned long long) in davxmlparser.cpp.o
  "_ne_xml_parse", referenced from:
      Davix::XMLSAXParser::parseChunk(char const*, unsigned long long) in davxmlparser.cpp.o
  "_ne_xml_push_handler", referenced from:
      Davix::XMLSAXParser::XMLSAXParser() in davxmlparser.cpp.o
      Davix::XMLSAXParser::XMLSAXParser() in davxmlparser.cpp.o
  "_populate_cert", referenced from:
      Davix::SSL_X509_Pem_Read(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, Davix::DavixError**) in davix_openssl.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [src/libdavix.0.7.5.dylib] Error 1
make[1]: *** [src/CMakeFiles/libdavix.dir/all] Error 2
make: *** [all] Error 2

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  https://github.com/cern-fts/homebrew-dmc/issues

These open issues may also help:
davix upgrade fails on MacOs Mojave https://github.com/cern-fts/homebrew-dmc/issues/5

I uninstalled 0.6.9 and then 0.7.5 installed fine. The upgrade is broken however.