Max Write: Increase to 19 items + adjust write overhead for PDU

cern-hse-computing · Nov 8, 2024 · 2865c04 · 2865c04
1 parent 245e6e0
commit 2865c04
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -18,7 +18,7 @@ project(
     LANGUAGES CXX
 )
 
-set(PROJECT_VERSION 1.0.1)
+set(PROJECT_VERSION 1.0.2)
 
 configure_file(config.h.in configured/config.h)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/configured)

diff --git a/RAMS7200LibFacade.cxx b/RAMS7200LibFacade.cxx
@@ -148,7 +148,7 @@ void RAMS7200LibFacade::WriteToPLC() {
         }
     }
     if(!addresses.empty()){
-        RAMS7200ReadWriteMaxN(addresses, items, 10, PDU_SIZE, OVERHEAD_WRITE_VARIABLE, OVERHEAD_WRITE_MESSAGE, Common::S7Utils::Operation::WRITE);
+        RAMS7200ReadWriteMaxN(addresses, items, 19, PDU_SIZE, OVERHEAD_WRITE_VARIABLE, OVERHEAD_WRITE_MESSAGE, Common::S7Utils::Operation::WRITE);
     }
     else
     {

diff --git a/RAMS7200LibFacade.hxx b/RAMS7200LibFacade.hxx
@@ -17,7 +17,7 @@
 
 #define OVERHEAD_READ_MESSAGE 13
 #define OVERHEAD_READ_VARIABLE 5
-#define OVERHEAD_WRITE_MESSAGE 12
+#define OVERHEAD_WRITE_MESSAGE 24
 #define OVERHEAD_WRITE_VARIABLE 16
 #define PDU_SIZE 240
-Original file line number
+Diff line change
@@ Expand Up / @@ -148,7 +148,7 @@ void RAMS7200LibFacade::WriteToPLC() { @@
             }
         }
         if(!addresses.empty()){
-            RAMS7200ReadWriteMaxN(addresses, items, 10, PDU_SIZE, OVERHEAD_WRITE_VARIABLE, OVERHEAD_WRITE_MESSAGE, Common::S7Utils::Operation::WRITE);
+            RAMS7200ReadWriteMaxN(addresses, items, 19, PDU_SIZE, OVERHEAD_WRITE_VARIABLE, OVERHEAD_WRITE_MESSAGE, Common::S7Utils::Operation::WRITE);
         }
         else
         {
@@ Expand Down @@