Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Resolve XFC conflict #5

Closed
pgross41 opened this issue Jun 4, 2019 · 5 comments
Closed

Resolve XFC conflict #5

pgross41 opened this issue Jun 4, 2019 · 5 comments

Comments

@pgross41
Copy link
Contributor

pgross41 commented Jun 4, 2019

Expanding the Console tab causes an infinite loop when using the XFC library https://github.com/cerner/xfc

@pgross41 pgross41 added this to the Backlog milestone Jun 4, 2019
@pgross41 pgross41 modified the milestones: Backlog, v1.1.0 Jun 21, 2019
@pgross41 pgross41 removed this from the v1.1.0 milestone Nov 14, 2019
@pgross41
Copy link
Contributor Author

Details in attached email
RE_ Steps to reproduce smart+mpage f-twelve issue.zip

@pgross41
Copy link
Contributor Author

Logged oracle-samples/xfc#45

@pgross41
Copy link
Contributor Author

The offending code is wrapped in if (process.env.NODE_ENV !== 'production'). Setting that manually does not work, the process variable is set within an MPage. The XFC readme says to set it with Webpack which should swap out the variable with a string literal. Quickly tested with adding that to a SMART app's webpack config but it doesn't seem to do anything. May need to set it in the cerner-smart-embeddable's webpack config or provide a means to skip it at run-time instead of build-time.

@pgross41
Copy link
Contributor Author

This PR oracle-samples/cerner-smart-embeddable-lib#27 should resolve the issue for webpack users.

Submitted an issue with XFC for non-webpack users: oracle-samples/xfc#45 (comment).

@pgross41
Copy link
Contributor Author

pgross41 commented Oct 4, 2020

Using XFC directly is not an issue, follow the usage instructions and disable logging. There is an issue with cerner-smart-embeddable-lib though.

Webpack users:
Include a version of cerner-smart-embeddable-lib with this change in it. As of right now it is not in a release. Follow XFC's readme instructions to disable logging.

Non-webpack users:
Copy and paste the precompiled script from the dist directory and remove or comment out the call to console.log.

@pgross41 pgross41 closed this as completed Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant