-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a version check on initial loading #131
Comments
How do you define for the first time? Should this state be saved in the browser as cookie or some other in-browser storage? The latest intelmq-manager release is 0.2.2. How will this file at intelmq.org be updated? Please be aware that not all users may want to have version update reminders, especially if updates are handled with some kind of package management. |
And also see #122 which shows the used version on the about page. |
To be open for definition. For example: set a cookie which expires in 1 day. Concerning the users who might not want to have that - okay, fair enough. But then they should have some global setting to disable that. By default it should be enabled. Yes, I am aware of #122. |
Concerning the update of the versions on intelmq.org: https://api.github.com/repos/certtools/intelmq/releases has a JSON-formatted file with all releases including the release notes == changelog. We can regularly get the latest version of this file and
Showing the changelog could be very effective to show the users what has been fixed/added without going to the changelog themselves |
please just implement as specified. Thx. |
I already mentionend some of the following statements in yesterdays dev call, now for transparency in public. I have no good feeling about the "latest version" feature, apart of the privacy concerns. But what I want to mention is:
@aaronkaplan: can you please specify in public why this feature is needed? Idea: What about a "check if your version is the most recent" - link to a webpage showing the most recent version-numbers.
|
When the manager is loaded (displayed) for the first time, it shall do a version check:
make a connection to https://intelmq.org/version.json and pull in the following json file:
After fetching the file, the manager shall compare it's own version and intelmq's version against the given versions in the file.
Please present the own version on the upper right side of the screen in small letters like:
And add a link to the corresponding github repos where the newest version may be downloaded.
Thanks!
The text was updated successfully, but these errors were encountered: