Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a version check on initial loading #131

Open
aaronkaplan opened this issue Aug 25, 2017 · 6 comments
Open

create a version check on initial loading #131

aaronkaplan opened this issue Aug 25, 2017 · 6 comments

Comments

@aaronkaplan
Copy link
Member

aaronkaplan commented Aug 25, 2017

When the manager is loaded (displayed) for the first time, it shall do a version check:

make a connection to https://intelmq.org/version.json and pull in the following json file:

{
	"intelmq-manager":	"1.0",
	"intelmq":	"1.0.1"
}

After fetching the file, the manager shall compare it's own version and intelmq's version against the given versions in the file.
Please present the own version on the upper right side of the screen in small letters like:

intelmq: installed ver. 0.9, latest: 1.0.1
manager: installed ver. 0.6, latest: 1.0

And add a link to the corresponding github repos where the newest version may be downloaded.

Thanks!

@ghost
Copy link

ghost commented Aug 28, 2017

How do you define for the first time? Should this state be saved in the browser as cookie or some other in-browser storage?

The latest intelmq-manager release is 0.2.2. How will this file at intelmq.org be updated?

Please be aware that not all users may want to have version update reminders, especially if updates are handled with some kind of package management.

@ghost
Copy link

ghost commented Aug 28, 2017

And also see #122 which shows the used version on the about page.

@aaronkaplan
Copy link
Member Author

aaronkaplan commented Aug 28, 2017

To be open for definition. For example: set a cookie which expires in 1 day.
Hence , we would have a daily version check. also ok.

Concerning the users who might not want to have that - okay, fair enough. But then they should have some global setting to disable that. By default it should be enabled.

Yes, I am aware of #122.

@ghost
Copy link

ghost commented Aug 28, 2017

Concerning the update of the versions on intelmq.org: https://api.github.com/repos/certtools/intelmq/releases has a JSON-formatted file with all releases including the release notes == changelog. We can regularly get the latest version of this file and

  • serve the latest version number, probably with release date, or
  • list all available versions -> allows the user to see all intermediate versions, release dates and probably the changelog

Showing the changelog could be very effective to show the users what has been fixed/added without going to the changelog themselves

@aaronkaplan
Copy link
Member Author

please just implement as specified. Thx.

@dmth
Copy link

dmth commented Aug 30, 2017

I already mentionend some of the following statements in yesterdays dev call, now for transparency in public.

I have no good feeling about the "latest version" feature, apart of the privacy concerns.
I don't want to discuss the "calling-home" feature now, because I suppose we all know about its implications.

But what I want to mention is:

  • I thought we'd do a "packaging first" approach, meaning all users installing IntelMQ and the IntelMQ-Manager with
    apt, yum or other tools, would get notified by their packaging system if new versions are available.
    Why should I notify the user in the web-GUI in such a case?

  • Not every user of the web-GUI is also allowed to update software on the server, as she/he has no admin-rights.
    How shall she/he react when seeing the outdated version? What should be achieved?

  • Not updating to the latest version is intentional in many cases when complex configuration is required.

  • I doubt that now is the right time to spend resources on such a feature. IMHO there are more important things.

@aaronkaplan: can you please specify in public why this feature is needed?

Idea: What about a "check if your version is the most recent" - link to a webpage showing the most recent version-numbers.
This approach can be split into multiple stages:

  1. Stage: Just a website showing the Versionnumbers
  2. Stage: When the link is clicked, the installed version-numbers are transferred to the Website. The Website just shows both numbers and a "check"-mark or a "cross"-mark.
  3. Stage: The Changelog is displayed for the Diff in versions.

@ghost ghost modified the milestones: Release 1.0, Release 1.1 Apr 23, 2018
@ghost ghost unassigned arnoesterhammer Apr 23, 2018
@ghost ghost modified the milestones: 1.1.0, 1.2.0 Nov 12, 2018
@ghost ghost modified the milestones: 1.2.0, 2.1.0 May 22, 2019
@ghost ghost modified the milestones: 2.1.0, 2.2.0 Feb 18, 2020
@ghost ghost removed this from the 2.2.0 milestone Jun 23, 2020
@ghost ghost added the help wanted label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants