Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Refactoring I #81

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

WIP - Refactoring I #81

wants to merge 16 commits into from

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented Nov 1, 2024 •
edited
Loading

A more flexible approach of doing plots.

Idea:

  • Axes are "real" plot objects that can be added via add-*-axis in the plot-body
  • The plot style is just a shortcut for adding a set of default axes
  • This allows creating sub-plots sharing an axis
  • Allows for 3D plots (at least very simple ones) without any special code

Plan:

  • Axes can draw themselves (ticks etc.)

Removing:

  • Axes are no longer auto created

@johannes-wolf johannes-wolf marked this pull request as draft November 1, 2024 00:57
@johannes-wolf johannes-wolf removed the request for review from jamesrswift November 1, 2024 02:39
@johannes-wolf johannes-wolf force-pushed the refactor-plot-part-one branch from 802122f to 6af8777 Compare November 1, 2024 13:27
@johannes-wolf johannes-wolf mentioned this pull request Nov 1, 2024
Closed
@jamesrswift jamesrswift mentioned this pull request Nov 1, 2024
Merged
3 tasks
jamesrswift
jamesrswift reviewed Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@jamesrswift jamesrswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the changed ref images to see if there were any regression - I've highlighted those files where I've spotted something, but mostly its some weird behaviour with annotations and marks, and ticks, which are changed.

tests/axes/log-mode/ref/1.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticks on auto-mirror axes are missing

tests/chart/boxwhisker/ref/1.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Border an mirror axes now present

tests/plot/annotation/ref/1.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations are improperly scaled

tests/plot/marks/ref/1.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markers are missing on some series

tests/plot/mirror-axes/ref/1.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticks and tick labels missing

@jamesrswift jamesrswift mentioned this pull request Nov 2, 2024
Open
@johannes-wolf johannes-wolf changed the title WIP WIP - Refactoring I Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrswift jamesrswift jamesrswift left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannes-wolf @jamesrswift