Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Chapter 5.6, grid_mapping can also be used for converting spatial bounds #590

Open
TomLav opened this issue Feb 7, 2025 · 4 comments · May be fixed by #589
Open

In Chapter 5.6, grid_mapping can also be used for converting spatial bounds #590

TomLav opened this issue Feb 7, 2025 · 4 comments · May be fixed by #589
Labels
enhancement Proposals to add new capabilities, improve existing ones in the conventions, improve style or format

Comments

@TomLav
Copy link

TomLav commented Feb 7, 2025

Title

In Chapter 5.6, grid_mapping can also be used for converting spatial bounds

Moderator

not assigned

Moderator Status Review [last updated: YYYY-MM-DD]

Brief comment on current status, update periodically

Requirement Summary

Since it isn't mandatory to provide 2D lat and lon auxiliary coordinate variables when the CRS and non-lat-lon 1D coordinate variables are provided, the same should apply to lat/lon bounds, because an application should be able to compute the bounds directly from the 1D bounds just like it can compute the lat/lon coordinates from the 1D coordinates. It's impossible anyway to provide lat/lon bounds if there are no lat/lon coordinate variables to attach them to.

Technical Proposal Summary

Insert a statement in Sec 5.6 "Horizontal Coordinate Reference Systems, Grid Mappings, and Projections" that the grid mapping information can be used to convert bounds as well as coordinates. At the moment it says nothing about bounds.

Benefits

This change will clarify that datasets provided in non lat/lon coordinate system, with a valid CRS, do not need to provide the full lat/lon bounds, only the bounds of the 1D coordinate variables, to express that the data variables are representative of cells (and not points). This might encourage data providers to provide said bounds (as it reduces file storage overhead).

Status Quo

This aspect (among others) was discussed here.

Associated pull request

#589

Detailed Proposal

A short paragraph about bounds is added to section 5.6, Horizontal Coordinate Reference Systems, ...

@TomLav TomLav added the enhancement Proposals to add new capabilities, improve existing ones in the conventions, improve style or format label Feb 7, 2025
@JonathanGregory
Copy link
Contributor

Thank you, Thomas. I support this change being made. I have made a couple of editorial comments in the PR. One further comment, on the words: I would suggest "the horizontal coordinates of the grid", instead of "easting and northings", for generality.

@TomLav
Copy link
Author

TomLav commented Feb 7, 2025

Thank you for the editorial comments. I will also implement your suggestion "easting and northing" -> "the horizontal coordinates of the grid" as it is more general. I used easting and northing because this is what is used at the top of the section.

@JonathanGregory
Copy link
Contributor

@TomLav. Since this is an enhancement, for which you have drafted the text as well as raising the need for it, please could you add yourself as an additional author of the convention in the PR. Also, the issue needs an entry in history.adoc. There should be heading for the new draft version in the Revision History. I've just created a PR to do this.

@TomLav
Copy link
Author

TomLav commented Feb 11, 2025

Done. Exciting to be the first edit towards v1.13 :-)
I suppose there is no need to update the conformance document, so I put N/A for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposals to add new capabilities, improve existing ones in the conventions, improve style or format
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants