Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFFDRS R Bug]: Poor stop condition, reformat to all #35

Open
2 tasks
BadgerOnABike opened this issue Jan 19, 2024 · 0 comments
Open
2 tasks

[CFFDRS R Bug]: Poor stop condition, reformat to all #35

BadgerOnABike opened this issue Jan 19, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@BadgerOnABike
Copy link
Collaborator

Contact Details

No response

What happened?

Currently using sort to determine if any falsey conditions exist, all would be superior

cffdrs_r/R/fbpRaster.r

Lines 342 to 357 in 23dc442

if (output == "SECONDARY" | output == "S") {
if (!sort(select %in% secondaryNames)[1]) {
stop("Selected variables are not in the outputs")
}
}
if (output == "PRIMARY" | output == "P") {
if (!sort(select %in% primaryNames)[1]) {
stop("Selected variables are not in the outputs")
}
}
if (output == "ALL" | output == "A") {
if (!sort(select %in% allNames)[1]) {
stop("Selected variables are not in the outputs")
}
}
}

Relevant log output

No response

Approvals Process

  • Testing For Issue
  • Merge
@BadgerOnABike BadgerOnABike added the bug Something isn't working label Jan 19, 2024
@BadgerOnABike BadgerOnABike self-assigned this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant