Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFFDRS R Bug]: D0 always output as 0 when requested #44

Open
2 tasks
gagreene opened this issue Aug 12, 2024 · 0 comments
Open
2 tasks

[CFFDRS R Bug]: D0 always output as 0 when requested #44

gagreene opened this issue Aug 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@gagreene
Copy link
Contributor

gagreene commented Aug 12, 2024

Contact Details

[email protected]

What happened?

Issue

  • In both the fbp and fbpRaster functions, when D0 is requested as an output, it is always returned as 0. This occurs when no D0 is provided by the user. The code appears to work as intended if the user supplies their own D0 value.

image

Cause

  • This appears to source back to foliar_moisture_content.r -- FMC is returned but D0 is not. So the value returned to the user is the initial D0 value, which was set to 0 in fire_behaviour_prediction.r.

Solution

  • Return both FMC and D0 from foliar_moisture_content.r
  • Assign output from foliar_moisture_content.r to FMC and D0 in fire_behaviour_prediction.r

Relevant log output

No response

Approvals Process

  • Testing For Issue
  • Merge
@gagreene gagreene added the bug Something isn't working label Aug 12, 2024
BadgerOnABike added a commit that referenced this issue Sep 18, 2024
… an effective date of minimum foliar moisture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants