Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add a status section when adding flags from django-admin. #112

Open
ArcD7 opened this issue Apr 24, 2023 · 2 comments
Open

Proposal: Add a status section when adding flags from django-admin. #112

ArcD7 opened this issue Apr 24, 2023 · 2 comments

Comments

@ArcD7
Copy link

ArcD7 commented Apr 24, 2023

Currently, when setting Flag states from django-admin it only shows the condition when flag is enabled but it is not trivial since flag can be both used for enabling and disabling a feature.

Can we make it in such a way that on one side it shows the condition when the flag is enabled and what is the value that is currently set.

Something like this:
Proposal django-flags

PS: The condition is also somewhat misleading, since I want to disable the feature when it is False, but the condition always says enabled.

I hope this is making sense!!

@willbarton
Copy link
Member

willbarton commented Apr 24, 2023

@ArcD7 That's not a bad idea — I'd like to do something more in the admin (wagtail-flags has a much richer view, but the Wagtail admin is somewhat easier to customizable and wagtail-flags is only useful if you're using Wagtail). As it is, the Django-Flags admin is very barebones.

One thing that may or may not be helpful for your immediate needs, Django-Flags has a Django Debug Toolbar panel that can describe flag conditions and state for the current request: https://cfpb.github.io/django-flags/debugging/

@ArcD7
Copy link
Author

ArcD7 commented Apr 24, 2023

@willbarton Thanks for the reply, unfortunately I'm not using wagtail. Maybe I can fork the library and work on the Django-Flags admin. Any ideas for a good starting point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants