Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion from Taylor R Campbell - Don't use Z twice #5

Closed
emanjon opened this issue Feb 28, 2024 · 2 comments
Closed

Suggestion from Taylor R Campbell - Don't use Z twice #5

emanjon opened this issue Feb 28, 2024 · 2 comments

Comments

@emanjon
Copy link
Collaborator

emanjon commented Feb 28, 2024

  • Added note that Z in step f is not reused from step d.

May I suggest using different letters for this, or numbered instances
like Z0 and Z1? It's confusing to define a function F(m, Z, Z) as
you're doing here where the two Z's are actually different parameters.

https://mailarchive.ietf.org/arch/msg/cfrg/jmfn1b880x7-7gZKb7_uwLvE3oU/
emanjon added a commit that referenced this issue Feb 28, 2024
@emanjon
Update draft-irtf-cfrg-det-sigs-with-noise.md
92fbeea 
#5
@emanjon
Copy link
Collaborator Author

emanjon commented Feb 29, 2024

Fixed in main

@emanjon emanjon closed this as completed Feb 29, 2024
@dannyniu
Copy link

dannyniu commented Mar 5, 2024 •
edited
Loading

Using different Z for steps d and f breaks PRNG boundary - RFC-6979 is essentially ECDSA plus a user-seeded HMAC-DRBG, using different Zs changes and breaks the PRNG algorithm. See Issue 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emanjon @dannyniu