Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename language pt_PT to pt #342

Open
bekuno opened this issue Jan 3, 2022 · 8 comments
Open

Rename language pt_PT to pt #342

bekuno opened this issue Jan 3, 2022 · 8 comments
Labels
Feature Request New feature or request Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility

Comments

@bekuno
Copy link
Member

bekuno commented Jan 3, 2022

Tell us your idea!

The language resolution strategy of android is described in https://developer.android.com/guide/topics/resources/multilingual-support#preN .
If we rename pt_PT to pt, then a system language configuration of pt_PT is mapped to pt, and a system language of pt is resolved directly.

@Lineflyer
We have a simular solution for zh_CN in c:geo.

What solution would you suggest?

No response

Is there an alternative?

No response

Additional Information

No response

@bekuno bekuno added Feature Request New feature or request Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility labels Jan 3, 2022
@Lineflyer
Copy link
Member

Its a language code mapping on Crowdin.
I could set this up easily, but what to do with brazilian then?

image

@Lineflyer
Copy link
Member

For comparison, that is what we use for c:geo:
image

@bekuno
Copy link
Member Author

bekuno commented Jan 3, 2022

Please look at Chinese Simplified (zh_CN).
How is Portuguese defined for c:geo?

Btw., I can´t found/see this mapping. Is it here on the Github integrations page?
(https://crowdin.com/project/whereyougo/apps/system/github)
grafik

The pt_BR should stay unchanged, like zh_TW for c:geo.
See also https://github.com/cgeo/cgeo/blob/master/main/build.gradle#L54

@Lineflyer
Copy link
Member

Its not bound to Github integration but a generic setting for the Crowdin project, you can find it in the settings in the section "export" behind "language mapping":
image

@Lineflyer
Copy link
Member

The pt_BR should stay unchanged, like zh_TW for c:geo.

That would mean I simply remove the pt to pr_rPT mapping then.
However there was a reason I did that...need to look through old issues first...I wouldn't have done it without need.

@Lineflyer
Copy link
Member

In #23 (comment) I noted down, that without this rPT theere is something missing from Crowdin....but we can try what happens.

Not sure if it will work as I also mention in that thread, that the change needs to be done before creating the integration to Github.

I will try that out as time permits, but can we stay with the hotfix provided until then or is it mandatory to change this before we can merge that PR?

@bekuno
Copy link
Member Author

bekuno commented Jan 3, 2022

Ok, found it.
The Chinese Simplified is mapping to the default 2-letter code.

I will try that out as time permits, but can we stay with the hotfix provided until then or is it mandatory to change this before we can merge that PR?

The PR is fine in the current implementation with a workaround for Portuguese pt.
After the change at crowdin this workaround should be removed.

@bekuno
Copy link
Member Author

bekuno commented Jan 3, 2022

In #23 (comment) I noted down, that without this rPT theere is something missing from Crowdin....but we can try what happens.

After reading the comment, I think we first need to rename the folder values-pt-rPT to values-pt .
Then remove the special mapping at crowdin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility
Projects
None yet
Development

No branches or pull requests

2 participants