diff --git a/pkg/bindings/containers/attach.go b/pkg/bindings/containers/attach.go index 94219174b829..a37b0e7377c7 100644 --- a/pkg/bindings/containers/attach.go +++ b/pkg/bindings/containers/attach.go @@ -29,7 +29,10 @@ type CloseWriter interface { CloseWrite() error } -// Attach attaches to a running container +// Attach attaches to a running container. +// +// NOTE: When the container is configured to use a tty and stdin is a tty, +// this currently leaks a goroutine reading from stdin even if the ctx is cancelled. func Attach(ctx context.Context, nameOrID string, stdin io.Reader, stdout io.Writer, stderr io.Writer, attachReady chan bool, options *AttachOptions) error { if options == nil { options = new(AttachOptions)