Events of attempts to reconnect

[GolDiV]

Is it possible to somehow get the events of attempts to reconnect to the asterisk websocket? Now it can be seen only through debug, but I want to process them on the client in production

[chadxz]

Hey Dmitriy! Thanks for the feedback. That isn't currently possible, but it wouldn't be a large code change. I can try to do that soon, or I would accept a PR for that functionality.

[chadxz]

retry.timeouts(opts) can be used to get the list of timeout values to be able to report how long until the next retry. In ReconnectingWebsocket.js we can alter both handleError and handleClose to set a private member variable to indicate we are reconnecting. Then in the connect method, check for that and emit an event on each connection attempt, along with some metadata about what attempt number it is, how many total attempts there will be, and the time until the next attempt. Lastly, we'd need to reset the reconnecting instance var once we exhaust our attempts or are successful.

And of course write tests 😊 (the hard part)

[GolDiV]

Hi Chad! I'm not a good programmer yet, so I can't do PR. However, I got your idea. I reasoned about the same.
Your project in my opinion is very interesting. I tried 'ari-client', but I liked 'awry' more.

[GolDiV]

And a few more points. If you start to connect to a remote server in the absence of a network, errors can also not be caught without debug. They simply have nowhere to catch as there is no websocket object. This object appears only when there is a connection, if I understand correctly.
The second point is related to ping. You have this undocumented, but it is done simply with events._ws.ping(). This makes it easy to detect a broken connection. I have not found another way to detect broken connections. However, maybe there is a better way?

[chadxz]

Thanks for the additional feedback Dmitriy 😊 I created #102 and #103 to track those and allow us to continue that discussion in a dedicated place.

Don't worry about the PR if you feel uncomfortable doing that. I think this feedback is great and would like to investigate these things and see if we can address them. My time is limited though so it may take a while 😅 I'm sure you understand.