Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update batch tool #6

Open
Nandayang opened this issue Sep 16, 2024 · 9 comments
Open

Update batch tool #6

Nandayang opened this issue Sep 16, 2024 · 9 comments

Comments

@Nandayang
Copy link

Nandayang commented Sep 16, 2024

I would like to update our harmonization tools and have uploaded the v2.0 version to
https://github.com/chaimeleon-eu/image_batch_lungCT_harmonisation/tree/main/V2.
Could you please integrate it into the platform? Many thanks.

@Nandayang Nandayang changed the title Updat Update batch tool Sep 16, 2024
@Palollo
Copy link
Member

Palollo commented Sep 16, 2024

Does V2 replace the previous version?

@Nandayang
Copy link
Author

Does V2 replace the previous version?

Yes, it could replace the previous version

@Palollo
Copy link
Member

Palollo commented Sep 18, 2024

17.2GB of image size!

Could you use the "runtime" version for the base image instead of the "devel"?
FROM pytorch/pytorch:2.1.2-cuda12.1-cudnn8-devel --> FROM pytorch/pytorch:2.1.2-cuda12.1-cudnn8-runtime
If possible it would be a good point to reduce the size to something more affordable.

Also it would be useful you check the recommendations in the guide.
In that way you can change that:

RUN apt-get update
RUN pip install numpy
RUN pip install SimpleITK
RUN pip install tqdm
RUN pip install scipy

Into that:

RUN pip install --no-cache-dir  numpy SimpleITK tqdm scipy

So if you agree and apply these changes, the image size finally would reduce to 7.66GB

@Nandayang
Copy link
Author

@Palollo Yes for sure, I've tested and everything works fine with the 'runtime' version.

@Palollo
Copy link
Member

Palollo commented Sep 18, 2024

Great, so it is already uploaded as:
harmonisation-lungct:2.0
harmonisation-lungct:latest

@Nandayang
Copy link
Author

@Palollo Another issue is that when I try to launch an application to test my batch tool, it always shows 'Not Ready 0 Pod', and I cannot access the remote service (I've tried both desktop-pytorch and jupyter pytorch).

@Palollo
Copy link
Member

Palollo commented Sep 19, 2024

This is something that can happen when there are not enough resources in that moment, because there are other desktops created by other users.
Just a reminder for anyone who read this: it is important to release (delete) the desktop when the work is finished to let the resources available to other users.
Anyway I can say currently there are resouces available to your desktop, @Nandayang, it should work if you try to launch ;)

@Nandayang
Copy link
Author

@Palollo Thanks for your help and it works now. Btw, I made some modifications to the script and could you please help me to update it on the platform? The path is still in https://github.com/chaimeleon-eu/image_batch_lungCT_harmonisation/tree/main/V2
Many thanks

@Palollo
Copy link
Member

Palollo commented Sep 25, 2024

OK, it's now updated on the platform as:

harmonisation-lungct:2.1
harmonisation-lungct:latest

You should update the dockerfile accordingly:

LABEL name="harmonisation-lungct"
LABEL version="2.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants