Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated mvCapture calls in capnproto-1.0.1 #87

Closed
ryanofsky opened this issue Oct 26, 2023 · 1 comment · Fixed by #88
Closed

Deprecated mvCapture calls in capnproto-1.0.1 #87

ryanofsky opened this issue Oct 26, 2023 · 1 comment · Fixed by #88

Comments

@ryanofsky
Copy link
Collaborator

Should be no need for mvCapture anymore with c++14 generalized lambdas

Originally posted by @maflcko in bitcoin/bitcoin#28735 (comment):

https://cirrus-ci.com/task/6337577544843264?logs=ci#L1948

  CXX      bitcoin_node-bitcoind.o
  CXX      init/bitcoin_node-bitcoin-node.o
  GEN      ipc/capnp/echo.capnp.h
  GEN      ipc/capnp/init.capnp.h
  CXX      ipc/capnp/libbitcoin_ipc_a-echo.capnp.o
  CXX      ipc/capnp/libbitcoin_ipc_a-init.capnp.o
  CXX      ipc/capnp/libbitcoin_ipc_a-echo.capnp.proxy-client.o
  CXX      ipc/capnp/libbitcoin_ipc_a-init.capnp.proxy-client.o
  CXX      ipc/capnp/libbitcoin_ipc_a-echo.capnp.proxy-server.o
  CXX      ipc/capnp/libbitcoin_ipc_a-init.capnp.proxy-server.o
  CXX      ipc/capnp/libbitcoin_ipc_a-echo.capnp.proxy-types.o
  CC       src/libsecp256k1_precomputed_la-precomputed_ecmult.lo
  CXX      ipc/capnp/libbitcoin_ipc_a-init.capnp.proxy-types.o
In file included from ipc/capnp/echo.capnp.proxy-server.c++:4:
/ci_container_base/depends/i686-pc-linux-gnu/include/mp/proxy-types.h:122:13: error: 'mvCapture<(lambda at /ci_container_base/depends/i686-pc-linux-gnu/include/mp/proxy-types.h:123:13), capnp::CallContext<ipc::capnp::messages::Echo::DestroyParams, ipc::capnp::messages::Echo::DestroyResults> &>' is deprecated: Use C++14 generalized captures instead. [-Werror,-Wdeprecated-declarations]
        kj::mvCapture(server_context.call_context,
            ^
@ryanofsky ryanofsky mentioned this issue Oct 26, 2023
Merged
@maflcko
Copy link

maflcko commented Oct 27, 2023

Related issues?

@ryanofsky ryanofsky mentioned this issue Nov 17, 2023
Merged
ryanofsky added a commit that referenced this issue Nov 17, 2023
@ryanofsky
Merge #88: Fix current deprecation warnings as of capnproto-1.0.1
414542f 
962e681 mpgen: Avoid deprecated SchemaParser::parseDiskFile call (Ryan Ofsky)
e8e89df Remove deprecated kj::mvCapture calls to avoid warnings (Ryan Ofsky)

Pull request description:

  This drops compatibility with capnproto versions before 0.7.0 and also adds a hard dependency on the kj/filesystem.h library which was previously optional

  Fixes #87 and #39

Top commit has no ACKs.

Tree-SHA512: fcfce7ec96c44eebba9e59f9d00c1a05f1c5189ecafa7331da87c130eb077d5c5c2cb92c57b00df9f16fd72a88d74a2f4c2604069e358e1783bc321635a0d5d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix current deprecation warnings as of capnproto-1.0.1 ryanofsky/libmultiprocess
2 participants
@maflcko @ryanofsky