You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: contributing.adoc
+8Lines changed: 8 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -27,3 +27,11 @@ When writing commit messages be sure to have read Chris Beams' "How to Write a G
27
27
As described in CONTRIBUTING.md, PRs should be prefixed with the component or area the PR affects.
28
28
Common areas are listed in CONTRIBUTING.md section: https://github.com/bitcoin/bitcoin/tree/master/CONTRIBUTING.md#creating-the-pull-request[Creating the pull request^].
29
29
Individual commit messages are also often given similar prefixes in the commit title depending on which area of the codebase the changes primarily affect.
30
+
31
+
[TIP]
32
+
====
33
+
Unless there is a merge conflict (usually detected by DrahtBot), don't rebase your changes on master branch before pushing.
34
+
If you avoid rebases on upstream, Github will show a very useful "Compare" button which reviewers can often use to quickly re-ACK the new changes if they are sufficiently small.
35
+
If you _do_ rebase this button becomes useless, as all the rebased changes from master get included and so a full re-review may be needed.
36
+
Developer review time is currently our major bottleneck in the project!
0 commit comments