Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comments #1

Open
albert-llimos opened this issue Mar 17, 2023 · 0 comments
Open

Fix comments #1

albert-llimos opened this issue Mar 17, 2023 · 0 comments
Assignees
@albert-llimos

Comments

@albert-llimos
Copy link
Collaborator

albert-llimos commented Mar 17, 2023 •
edited
Loading

The documentation on OneMinusPercSwap for TickInfo limit (in SharedLimitOrder.py) is wrong. It says it has relative meaning, but that's not true. It has absolute meaning.

Also, TickInfoLimit.feeGrowthInsideX128 says that it only has relative meaning depending when the tick was initialized. That's incorrect, that's legacy comments from range order's TickInfo.feeGrowthOutside0X128. For the limit orders, that has absolute meaning.
@albert-llimos albert-llimos self-assigned this Mar 17, 2023
@albert-llimos albert-llimos changed the title Comments Fix comments Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albert-llimos albert-llimos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@albert-llimos