Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ideas/improvements #2

Open
2 of 5 tasks
vivi365 opened this issue Jun 12, 2024 · 2 comments
Open
2 of 5 tasks

ideas/improvements #2

vivi365 opened this issue Jun 12, 2024 · 2 comments

Comments

@vivi365
Copy link
Collaborator

vivi365 commented Jun 12, 2024

  • Verify local binary option--local
  • Verify unstable option --unstable hash
  • Automatically fetch correct geth version for unstable builds (needed for URL)
  • Uniquely name binaries copied from docker?
  • latest as an alias for most recent stable build
@vivi365 vivi365 changed the title Feature ideas ideas/improvements Aug 3, 2024
@vivi365
Copy link
Collaborator Author

vivi365 commented Aug 14, 2024

Run rebuilder on server:

  1. scrape for new stable (unstable) releases
  2. rebuild
  3. report the results on eg the web, including any diff report

@vivi365
Copy link
Collaborator Author

vivi365 commented Aug 14, 2024

Capture specific errors messages from failed docker builds. This I think requires following the docker logs (docker logs --follow) during the docker build, which means i probably have to refactor the docker build command execution in DockerRebuild to run from a sh script instead.

At the moment we only get eg.

  "ERROR": "command failed: 
docker build -t rebuild-geth-v1.14.8-1cf3b5d38ac64921819b8e999d194047c84c4126-linux-amd64-2024-08-13-08.55 --progress=plain --build-arg=CGO_ENABLED=1 --build-arg=URL_SLUG=geth-linux-amd64-1.14.8-unstable-1cf3b5d3 --build-arg=GETH_VERSION=1.14.8 --build-arg=TOOLCHAIN_DEPS=gcc-multilib --build-arg=ARCH=amd64 --build-arg=COMMIT=1cf3b5d38ac64921819b8e999d194047c84c4126 --build-arg=GO_VERSION=1.22.6 \"--build-arg=BUILD_CMD=go run build/ci.go install -dlgo\" --build-arg=ELF_TARGET=elf64-x86-64 --build-arg=GOARM= \"--build-arg=UTIL_DEPS=git ca-certificates wget binutils\" --build-arg=UNSTABLE=true --build-arg=OS=linux --build-arg=UBUNTU_DIST=bionic --build-arg=SHORT_COMMIT=1cf3b5d3 /Users/viviandersson/geth-rebuild\nerror: exit status 1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant