[MERGE #6484 @pleath] Eliminate timezone sensitivities in UT's

Merge pull request #6484 from pleath:timezone-1.11 In some tests, convert Date objects to date strings before displaying them to eliminate timezone sensitivity. In other tests, prevent Microbuild from running the tests to eliminate noise due to timezone.
chakra-core · Jul 14, 2020 · 75d5a92 · 75d5a92
2 parents 906f833 + 56c47ac
commit 75d5a92
Show file tree

Hide file tree

Showing 10 changed files with 710 additions and 722 deletions.
diff --git a/test/Date/rlexe.xml b/test/Date/rlexe.xml
@@ -4,7 +4,7 @@
     <default>
       <files>DateCtr.js</files>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
-      <tags>exclude_jenkins</tags>
+      <tags>exclude_jenkins,slow</tags>
     </default>
   </test>
   <test>
@@ -13,15 +13,15 @@
       <baseline>DateGetSet.baseline</baseline>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
       <!-- XPLAT doesn't provide expected DST info for year 35816 -->
-      <tags>exclude_jenkins,exclude_xplat</tags>
+      <tags>exclude_jenkins,exclude_xplat,slow</tags>
     </default>
   </test>
   <test>
     <default>
       <files>DateParse.js</files>
       <baseline>DateParse_es5.baseline</baseline>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
-      <tags>exclude_jenkins</tags>
+      <tags>slow,exclude_jenkins</tags>
     </default>
   </test>
   <test>
@@ -30,7 +30,7 @@
       <baseline>DateParse2.v5.baseline</baseline>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
       <!-- xplat DST info for BC years don't mach to ones for Windows. Internally trying to match them is very expensive -->
-      <tags>exclude_jenkins,exclude_xplat</tags>
+      <tags>slow,exclude_jenkins,exclude_xplat</tags>
     </default>
   </test>
   <test>
@@ -68,7 +68,7 @@
       <baseline>Conversions.win8.baseline</baseline>
       <compile-flags>-Intl-</compile-flags>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
-      <tags>exclude_win7,exclude_winBlue,exclude_snap,exclude_jenkins,exclude_xplat</tags>
+      <tags>exclude_win7,exclude_winBlue,exclude_snap,exclude_jenkins,exclude_xplat,slow</tags>
     </default>
   </test>
   <test>
@@ -77,7 +77,7 @@
       <baseline>Conversions.baseline</baseline>
       <compile-flags>-Intl-</compile-flags>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
-      <tags>exclude_win7,exclude_win8,exclude_snap,exclude_jenkins,exclude_xplat</tags>
+      <tags>exclude_win7,exclude_win8,exclude_snap,exclude_jenkins,exclude_xplat,slow</tags>
     </default>
   </test>
   <test>
@@ -91,7 +91,7 @@
     <default>
       <files>formatting_xplat.js</files>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
-      <tags>exclude_jenkins,exclude_windows</tags>
+      <tags>slow,exclude_jenkins,exclude_windows</tags>
     </default>
   </test>
   <test>
@@ -102,7 +102,7 @@
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
       <!-- on DST pass Win OldDateAPI jumps back to 01:00 after 01:59 -->
       <!-- todo: Do not force OLDDateAPI ? -->
-      <tags>exclude_jenkins,exclude_xplat</tags>
+      <tags>slow,exclude_jenkins,exclude_xplat</tags>
     </default>
     <condition order="1" type="include">
       <os>win8</os>
@@ -141,7 +141,7 @@
       <files>toStringAndToUTCStringYearPadding.js</files>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
       <!-- xplat tz info for BC != Windows tz info for BC -->
-      <tags>exclude_jenkins,exclude_xplat</tags>
+      <tags>slow,exclude_jenkins,exclude_xplat</tags>
       <compile-flags>-args summary -endargs</compile-flags>
     </default>
   </test>
@@ -165,7 +165,7 @@
       <baseline>parseValidISO.baseline</baseline>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
       <!-- xplat tz info for BC != Windows tz info for BC -->
-      <tags>exclude_jenkins,exclude_xplat</tags>
+      <tags>slow,exclude_jenkins,exclude_xplat</tags>
       <compile-flags>-args summary -endargs</compile-flags>
     </default>
   </test>
@@ -175,7 +175,7 @@
       <baseline>parseInvalidISO.baseline</baseline>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
       <!-- OSX doesn't provide expected DST for minus years -->
-      <tags>exclude_jenkins,exclude_xplat</tags>
+      <tags>slow,exclude_jenkins,exclude_xplat</tags>
     </default>
   </test>
 </regress-exe>
diff --git a/test/GlobalFunctions/rlexe.xml b/test/GlobalFunctions/rlexe.xml
@@ -60,7 +60,7 @@
       <files>InternalToString.js</files>
       <baseline>InternalToString.baseline</baseline>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
-      <tags>exclude_jenkins</tags>
+      <tags>exclude_jenkins,slow</tags>
     </default>
   </test>
   <test>

diff --git a/test/JSON/rlexe.xml b/test/JSON/rlexe.xml
@@ -11,7 +11,7 @@
       <files>jx2.js</files>
       <baseline>jx2.baseline</baseline>
       <!-- test is timezone-sensitive; remove exclude_jenkins after fix (Microsoft/ChakraCore#319) -->
-      <tags>exclude_jenkins</tags>
+      <tags>exclude_jenkins,slow</tags>
     </default>
   </test>
   <test>