Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning a team catchup #8

Open
rhuanjl opened this issue May 15, 2020 · 25 comments
Open

Planning a team catchup #8

rhuanjl opened this issue May 15, 2020 · 25 comments

Comments

@rhuanjl
Copy link
Contributor

rhuanjl commented May 15, 2020

I think it would be good if we could have a catch up and discuss the current short term plan. Ideally at some point in the next two weeks.

@zenparsing
@chicoxyzzy
@Fly-Style
@ppenzin

We initially said we'd consider doing a release of some kind in June - I think we should still work for that but probably the latter half of the month? Also need to consider what it's feasible to do for that release.

Notably I'd originally hoped to have the RegExp system fully fixed up to ES6 level at least but I'm not going to manage that, the unicode matching feature is too big a piece of work for me to do in my available time in the next few weeks - particularly as it would need thorough testing and reviewing afterwards, so I think that one is going to have to slip.

I would like us to consider:

  • what we can do before a June release
  • what our approach to the API should be including what changes we should make before release (the API is very easy to edit code-wise so such changes are more about the decisions that underpin them than the work)
  • how we should go about producing a release

Please could you suggest:

  • anything else we should all discuss
  • when would be a good time for you, (maybe suggest days that are possible and I'll collate and propose something)
@Fly-Style
Copy link

Fly-Style commented May 15, 2020

I absolutely agree with @rhuanjl.
I am available every day from 8 AM to 11 PM GMT+3.

@ppenzin
Copy link
Member

ppenzin commented May 16, 2020

My schedule is pretty open too, though I usually appear either before 10 AM or after 5 PM Pacific Time (GMT-7, I think).

@chicoxyzzy
Copy link

I usually available 18:00 - 21:00 (GMT+3) every day except Thursday. Also can find a window between 12:00 and 18:00 sometimes.

@Fly-Style Sasha, if I'm not mistaken, your timezone is also GMT+3 (summer time) 🙂

@chicoxyzzy
Copy link

@rhuanjl is this meeting open for everyone? We can invite people to collaborate on twitter or elsewhere if so.

@rhuanjl
Copy link
Contributor Author

rhuanjl commented May 16, 2020

@chicoxyzzy I hadn't planned on it - but happy to go with majority opinion, @ppenzin @Fly-Style @zenparsing thoughts? Should we say this discussion is open to all?

@Fly-Style
Copy link

@rhuanjl I vote for an open meeting.

@ppenzin
Copy link
Member

ppenzin commented May 17, 2020

We are an open source project, so having an open meeting is fine. Discussing minute details of what each of us is going to try implement before release might not be interesting to the wider audience, but open format would be invaluabe for API feedback.

@ppenzin
Copy link
Member

ppenzin commented May 17, 2020

By the way, for talking about API with a wider audience, it would be useful to invite people who participated in threads on embedding in Microsoft/ChakraCore.

@rhuanjl
Copy link
Contributor Author

rhuanjl commented May 17, 2020

Looks like we'll go with an open meeting.
@zenparsing could you suggest your availability? Then I'll suggest a time.

I'm provisionally thinking 25th May, which should give a bit of time to pull together a more detailed agenda including some specifics of what to go through about the API and specific actions to discuss for work towards a release.

@rhuanjl
Copy link
Contributor Author

rhuanjl commented May 19, 2020

I'm hoping @zenparsing can join us.

But either way let's provisionally schedule this meeting for 5pm UTC on the 25th May - hopefully that works for everyone.

To do the time zone swaps that should be:

I'll try and prepare up a slightly more detailed agenda including some more detailed information about the API and issues to discuss with that as well as details of a release plan we can hash through

Feel free to invite anyone that may be interested in contributing to or using chakracore

Here's a zoom link to use, or ID and password below (zoom forces you to set a password even for a public meeting):
https://us04web.zoom.us/j/73990150188?pwd=YmJrdS8zdmxIdmRmUlVzblNpRm9MUT09

Meeting ID: 739 9015 0188
Password: 2HAfGC

@rhuanjl
Copy link
Contributor Author

rhuanjl commented May 25, 2020

I've added a fuller agenda here: https://github.com/chakra-core/org/blob/master/Meeting%20Agenda%2025-05-20.md

I'll aim to lead us through discussing these points on the call though will also give time for any other business.

@chicoxyzzy
Copy link

Oh sorry folks, I forgot about the meeting and won't be able to join right now 🤦‍♂️

@rhuanjl
Copy link
Contributor Author

rhuanjl commented May 25, 2020

Well this was a bust. Could we have an alternative time that we can all do?

Based on everyone's availabilities above 5pm UTC seems like a sensible time, but what day? (I can't do thursdays or sundays but the rest are good for me)

@ppenzin
Copy link
Member

ppenzin commented May 25, 2020

Ah, I am sorry, it is a long weekend in the US and it totally slipped my mind - I just got back home. I won't be able to make Wednesday (which is Tuesday evening in Europe), everything else is fine.

@rhuanjl
Copy link
Contributor Author

rhuanjl commented May 25, 2020

How about to give a bit of time and not be in a rush about this we try 5pm UTC on the 1st June (a week today)?

Can everyone confirm if that will work or suggest alternatives?
@chicoxyzzy @ppenzin @Fly-Style @zenparsing

@ppenzin
Copy link
Member

ppenzin commented May 25, 2020

(edited) I jumped the gun - I can do 5:30, have a conflict for the first half an hour.

@Fly-Style
Copy link

Fly-Style commented May 25, 2020

@rhuanjl It's fine for me!

@rhuanjl
Copy link
Contributor Author

rhuanjl commented Jun 1, 2020

So based on above, let's try and do this 5:30pm UTC today. Same meeting details as above.

@chicoxyzzy
Copy link

I won't be able to join this week because of TC39 meeting

@rhuanjl
Copy link
Contributor Author

rhuanjl commented Jun 1, 2020

Should we defer again - and see when everyone can actually do this time?

@chicoxyzzy
Copy link

I think that if you'll have a meeting notes, I just could catch up later.

@rhuanjl
Copy link
Contributor Author

rhuanjl commented Jun 3, 2020

@Fly-Style @ppenzin and I met on Monday and agreed the following short term actions:

  • 1. team action: Plan an API discussion advertised to the community for a later time.
  • 2. ppenzin: Setup a mirror repository with automated sync to microsoft/chakracore and pipelines which will facilitate us posting a release there
  • 3. Fly-Style: setup a team contact address that syncs to our discord
 (can be used for security reports and fuzzing)
  • 4. rhuanjl: Arrange for OSS-Fuzz to fuzz chakracore (Dependent on 3 & 4)
  • 5. rhuanjl: Adopt the generators work in @zenparsing's absence and get it merged, also open some follow ups after that is merged
  • 6. Fly-Style: update Wasm opcode definitions
  • 7. Team action: someone else to review rhuanjl's open PRs
  • 8. Team action: revisit a planned release when all these points done.

@rhuanjl
Copy link
Contributor Author

rhuanjl commented Jun 4, 2020

@chicoxyzzy From your tc39 involvement, do you know if there's a definitive list of normative PRs to the spec that have been merged - or would the best way to make such a list be just to filter the closed PRs in the spec repo? I'd like to make to extend my feature tracker to include Normative PRs too: https://github.com/chakra-core/org/blob/master/tc39%20Proposals.md

@chicoxyzzy
Copy link

@rhuanjl the best way for this I'm aware of is (as you said 🙂) looking at the list of merged PRs with "normative change" label https://github.com/tc39/ecma262/pulls?q=is%3Apr+is%3Aclosed+label%3A%22normative+change%22

For spec conformance it's also necessary to test against Test262 suit.

@rhuanjl
Copy link
Contributor Author

rhuanjl commented Jun 4, 2020

@rhuanjl the best way for this I'm aware of is (as you said 🙂) looking at the list of merged PRs with "normative change" label https://github.com/tc39/ecma262/pulls?q=is%3Apr+is%3Aclosed+label%3A%22normative+change%22

For spec conformance it's also necessary to test against Test262 suit.

Thanks, ah well I was hopeful but... I'm aware of the necessity of test262 testing - I've used the relevant test 262 tests whenever I've implemented a feature.

Looking at creating a script to run CC against the whole suite in an efficient fashion but that will take a little while: chakra-core/ChakraCore#6432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants