Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student publications tool 1.10.x: Feedback on work emails are sent to all teachers of a course #1407

Open
jderriks opened this issue Sep 15, 2016 · 7 comments
Assignees
Milestone

Comments

@jderriks
Copy link
Contributor

jderriks commented Sep 15, 2016

Teachers complain that they get email from students in course groups that they are not tutor of.
This email is sent to all teachers of a course when a student adds a "feedback" comment to his uploaded work (through group Assignments)
And it looks like this email option cannot be switched off which can cause a lot of email traffic.

diff --git a/main/work/work.lib.php b/main/work/work.lib.php
index 043bcaf..b3b263b 100755
--- a/main/work/work.lib.php
+++ b/main/work/work.lib.php
if (api_is_allowed_to_edit()) {
@@ -3144,7 +3144,7 @@ function addWorkComment($courseInfo, $userId, $parentWork, $work, $data)
$courseInfo['code']
);
if (!empty($teachers)) {

  •            $userIdListToSend = array_keys($teachers);
    
  •    //        $userIdListToSend = array_keys($teachers);
         }
     } else {
         $teachers = SessionManager::getCoachesByCourseSession(
    
@ywarnier ywarnier added this to the 1.11.0 milestone Oct 9, 2016
@jmontoyaa
Copy link
Member

That was the idea of that feature.

@jmontoyaa jmontoyaa assigned ywarnier and unassigned jmontoyaa Oct 11, 2016
@jderriks
Copy link
Contributor Author

jderriks commented Oct 11, 2016

Then it is a well un-documented feature and a big surprise if a course has many teachers!
Enhancement: course option to switch email notifications for assignments (student work) off for that course (or per assignment).

@ywarnier
Copy link
Member

Jan, how many teachers do you have in one single course? Wouldn't you be (somewhat wrongly) sharing a course between teachers instead of using sessions?
A normal course shouldn't have more than 3 teachers, in principle. One main teacher and two assistants, I can imagine, but more than that I'm not sure of the objective of having one single course shared between more teachers (except putting them one against the other because they eventually end up deleting files from some other teacher)...

@ywarnier ywarnier removed this from the 1.11.0 milestone Oct 12, 2016
@jderriks
Copy link
Contributor Author

jderriks commented Oct 12, 2016

Hi Yannick,
Sessions is indeed something we should try. It is interesting however that using groups we can accomplish almost the same. And groups have some advantages over sessions.

Our education model is not just based on lessons with 1 teacher and some classes. Example: we have a project (=course) with 138 student-teams (groups) and a 56 different teachers with several roles that project (about 770 students in total).

The main reason NOT to use sessions is: delegation of administrative tasks. Students can subscribe themselves to the right group so no need to create classes or putting the right student in the right session. Same for teachers: 56 in one course saves us the trouble of administering who needs access to what group.

I was hoping the "self-subscribe to session" enhancement would be implemented at some time. Maybe it is true that with using sessions we can do the same as we do with groups now but the user administration is holding us back. Groups are great.

@ywarnier
Copy link
Member

ywarnier commented Oct 12, 2016

Interesting use case. We're confirming the speakers of Chamilo Conference Cartagena at the moment. If we still have empty spaces, I'll probably send you an invite to speak remotely about that if you like :-)

In the meantime, for your issue, we have no direct plans of adding this feature, but if this is urgent, please consider finding someone near you to develop it and then contribute it, or otherwise contact the Chamilo official providers for a quote.

I'll leave the task open, but just so you know... no direct plans for this (and our plate is already really full with plans).

@jderriks
Copy link
Contributor Author

jderriks commented Dec 3, 2016

Catagena looks nice and warm - my collegue (from Colombia) says he'd loved to have a house there.
"Largest elearning conference in South America" sounds very promising for Chamilo too!

btw I'm still looking for a github auto-translate button to read Spanish and French issues :-)

@ywarnier ywarnier added this to the 3.0 milestone Mar 9, 2018
@stale
Copy link

stale bot commented Jul 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants