Internal: Make password edition a single independent page - refs BT#21546 #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -69,4 +73,44 @@ public function edit(Request $request, UserRepository $userRepository, Illustrat | |||
| 'user' => $user, | |||
| ]); | |||
| } | |||
|
|
|||
| #[Route('/change-password', name: 'chamilo_core_account_change_password', methods: ['GET', 'POST'])] | |||
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| @@ -69,4 +73,44 @@ | |||
| 'user' => $user, | |||
| ]); | |||
| } | |||
|
|
|||
| #[Route('/change-password', name: 'chamilo_core_account_change_password', methods: ['GET', 'POST'])] | |||
| public function changePassword(Request $request, UserRepository $userRepository, CsrfTokenManagerInterface $csrfTokenManager): Response | |||
There was a problem hiding this comment.
You must use "/**" style comments for a function comment
| $user->setPlainPassword($newPassword); | ||
| $userRepository->updateUser($user); | ||
| $this->addFlash('success', 'Password changed successfully.'); | ||
| return $this->redirectToRoute('chamilo_core_account_home'); |
There was a problem hiding this comment.
Missing blank line before return statement
| @@ -0,0 +1,43 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
Add a single space around assignment operators
| use Symfony\Component\OptionsResolver\OptionsResolver; | ||
| use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface; | ||
|
|
||
| class ChangePasswordType extends AbstractType |
|
Code Climate has analyzed commit 2e4ab27 and detected 12 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
…ssword page - refs BT#21546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.