Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spree 4.6 #953

Open
4 tasks done
theachoem opened this issue Jan 2, 2024 · 1 comment · Fixed by #960 · May be fixed by #968
Open
4 tasks done

Upgrade to Spree 4.6 #953

theachoem opened this issue Jan 2, 2024 · 1 comment · Fixed by #960 · May be fixed by #968
Assignees
Labels
M 1 to 1.5 days to make it ready migration

Comments

@theachoem
Copy link
Collaborator

theachoem commented Jan 2, 2024

Changes

BIG change of spree 4.6 is translation. It only has a few updates that break the current 4.5 that we are using.

Task breakdown:

  • Upgrade to ~> 4.6.0 which mean >= 4.6 < 4.7 in spree_cm_commissioner.gemspec
  • Check new features
    1. Translations: new translation available for following models:
      Spree::Product, Spree::Taxon, Spree::Taxonomy, Spree::Property, Spree::ProductProperty, Spree::OptionType, Spree::OptionValue, Spree::Store
    2. New webhook subscriber secret_key
    • In 4.6, it introduce secret_key for webhook subscriber.
      • secret_key will be used to generate signature for webhook payload
      • which then set to headers['X-Spree-Hmac-SHA256'] when send the event to the subscriber.
  • Check if UI breaks
  • Make sure all spec/tests passed

Demo

References

@theachoem theachoem self-assigned this Jan 3, 2024
@theachoem
Copy link
Collaborator Author

theachoem commented Jan 3, 2024

Thing that can break commissioner is not in 4.6, it's 4.7. I have created an issue for migrating to 4.7 #959
Spree 4.7 allows us to customize tabs & menu bars with rails code without using deface, we do a lot of defaces for tabs, so we need to migrate from deface to rails code in the initializer or engine instead.

@theachoem theachoem added this to the Upgrade to Spree 4.7 milestone Jan 3, 2024
@theachoem theachoem added migration M 1 to 1.5 days to make it ready labels Jan 3, 2024
theachoem added a commit that referenced this issue Jan 3, 2024
@theachoem theachoem linked a pull request Jan 3, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this to 📒 Backlog in Spree CM Commissioner Jan 3, 2024
@theachoem theachoem moved this from 📒 Backlog to 👀 In review in Spree CM Commissioner Jan 3, 2024
@theachoem theachoem moved this from 👀 In review to 🏗 In progress in Spree CM Commissioner Jan 3, 2024
theachoem added a commit that referenced this issue Jan 3, 2024
theachoem added a commit that referenced this issue Jan 3, 2024
theachoem added a commit that referenced this issue Jan 3, 2024
theachoem added a commit that referenced this issue Jan 3, 2024
@theachoem theachoem moved this from 🏗 In progress to 👀 In review in Spree CM Commissioner Jan 3, 2024
@theachoem theachoem mentioned this issue Jan 5, 2024
3 tasks
channainfo pushed a commit that referenced this issue Jan 5, 2024
theachoem added a commit that referenced this issue Jan 5, 2024
@theachoem theachoem linked a pull request Jan 8, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M 1 to 1.5 days to make it ready migration
Projects
Status: 👀 In review
1 participant