Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ellipsis to Badge #2591

Open
yangwooseong opened this issue Jan 16, 2025 · 1 comment
Open

Add ellipsis to Badge #2591

yangwooseong opened this issue Jan 16, 2025 · 1 comment
Labels
enhancement Issues or PR related to making existing features better good first issue Issue that good for newcomers

Comments

@yangwooseong
Copy link
Collaborator

Description

Badge 컴포넌트 안에 텍스트가 길어질 경우를 대비에 ellipsis 할 수 있는 옵션을 추가합니다.

Reasons for suggestion

Image

이런 식으로 텍스트 길이가 길어질 때 원하지 않는 줄 바꿈이 일어납니다.

Proposed solution

Text 컴포넌트와 마찬가지로 truncated props 를 주면 좋을 것 같습니다.

References

No response
@yangwooseong yangwooseong added the status:need triage Issue or PR that need triage attention label Jan 16, 2025
@channeltalk ChannelTalk
Copy link

channeltalk bot commented Jan 16, 2025

https://desk.channel.io/#/channels/1/team_chats/groups/1237/67889a01d8d61dcb83e9

@yangwooseong yangwooseong added good first issue Issue that good for newcomers enhancement Issues or PR related to making existing features better and removed status:need triage Issue or PR that need triage attention labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issues or PR related to making existing features better good first issue Issue that good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yangwooseong