Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook for logging request? #124

Open
jrubinator opened this issue Jun 28, 2019 · 6 comments
Open

Hook for logging request? #124

jrubinator opened this issue Jun 28, 2019 · 6 comments
Labels

Comments

@jrubinator
Copy link

jrubinator commented Jun 28, 2019

I have a use case for logging some information about the request (what headers were actually sent). Does adding a hook/callback just before $handle->write_request($request); sound reasonable? If so, I can submit a patch for that.

@jrubinator
Copy link
Author

@xdg - do you have any opinion on this?

@xdg
Copy link
Collaborator

xdg commented Aug 1, 2019

Hi. I'm not actively doing Perl development on this module, so I have to abstain, as I wouldn't be responsible for reviewing or merging.

@jrubinator
Copy link
Author

Ah, is @chansen the correct person to ask now?

@jrubinator
Copy link
Author

@chansen any thoughts?

@karenetheridge
Copy link
Contributor

This isn't a vote one way or another, but just an observation -- adding hooks would make this module less tiny. LWP::UserAgent already supports hooks, so you might find your usecase better served there.

@xdg
Copy link
Collaborator

xdg commented Jul 19, 2021

Another possibility could be intercepting the data written to the output handle, which would be a way to address debugging needs like #123.

@xdg xdg added the Wishlist label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants