Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort plausible event should only be sent on user click #647

Open
codemonkey800 opened this issue Aug 31, 2022 · 2 comments
Open

Sort plausible event should only be sent on user click #647

codemonkey800 opened this issue Aug 31, 2022 · 2 comments
Labels
bug Something isn't working frontend P1 High Priority

Comments

@codemonkey800
Copy link
Collaborator

Description

The sort plausible event should only be sent when a user clicks on a sort option.

Steps/Code to Reproduce

  1. Go to https://napari-hub.org
  2. Enter search term

Expected Results

Sort event should not be sent when switched to Relevance automatically

Actual Results

Sends sort event when switched to Relevance automatically

@codemonkey800 codemonkey800 added the bug Something isn't working label Aug 31, 2022
@kandarpksk
Copy link
Contributor

Copying Ben's question from chat: what's the case where someone searches but sort [event] doesn't get triggered? since there are slightly fewer sort goals than search goals..

@codemonkey800
Copy link
Collaborator Author

Checked on prod and I think a relevance sort option will always be triggered when searching @bnelson-czi

@richaagarwal richaagarwal moved this to Backlog in napari hub backlog Jul 28, 2023
@codemonkey800 codemonkey800 added the P1 High Priority label Aug 2, 2023
@richaagarwal richaagarwal moved this from Backlog to Icebox in napari hub backlog Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend P1 High Priority
Projects
Status: Icebox
Development

No branches or pull requests

2 participants