Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gene info panel e2e test for staging and prod #1157

Open
tihuan opened this issue Jan 8, 2025 · 2 comments
Open

Enable gene info panel e2e test for staging and prod #1157

tihuan opened this issue Jan 8, 2025 · 2 comments
Assignees
@kaloster
Labels
P1 Priority 1 - Improvement with wide impact, fix within 1 week testing

Comments

@tihuan
Copy link
Contributor

tihuan commented Jan 8, 2025

Per this PR: https://github.com/chanzuckerberg/single-cell-explorer/pull/1151/files

The test is currently skipped due to gene info endpoint returning null in rdev. However, since the endpoint works for staging and prod, it might be valuable to enable the test for staging and prod

This will involve checking if the test is running in staging or prod to conditionally run the test!
@tihuan tihuan added the testing label Jan 8, 2025
@tihuan
Copy link
Contributor Author

tihuan commented Jan 8, 2025

CC: @kaloster for visibility!

@kaloster kaloster self-assigned this Jan 8, 2025
@tihuan tihuan added the P1 Priority 1 - Improvement with wide impact, fix within 1 week label Jan 8, 2025
@tihuan
Copy link
Contributor Author

tihuan commented Jan 8, 2025

Setting P1, since it's not mission critical but a nice to have for test coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaloster kaloster

Labels
P1 Priority 1 - Improvement with wide impact, fix within 1 week testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tihuan @kaloster