Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize #892

Open
tihuan opened this issue Apr 25, 2024 · 4 comments
Open

Resize #892

tihuan opened this issue Apr 25, 2024 · 4 comments
Labels
frontend front-end issue P2 Priority 2 - Improvement with narrower impact, fix within a month

Comments

@tihuan
Copy link
Contributor

tihuan commented Apr 25, 2024

Figure out how OSD and custom canvas resize with the same scale. Currently the custom layer shrinks a lot more and OSD doesn’t really resize?

DoD:

  1. Resizing the viewport should keep the OSD and custom layer in sync

NOTES:

  1. Timmy: Hopefully we just need to call OSD resize somewhere
@tihuan tihuan added frontend front-end issue P0 Priority 0 - Critical, fix ASAP! labels Apr 25, 2024
@tihuan
Copy link
Contributor Author

tihuan commented May 8, 2024

@kaloster @seve if either of you could investigate this further that'd be great!

The issue I ran into so far is that even though zooming and panning both OSD and custom layer are in sync, when resizing the window, somehow they resize VERY differently

My observation is that the custom layer seems to resize and leave quite a bit of paddings around the viewport, so not sure if there's some hard coded padding somewhere when resizing?

On the other hand, OSD default resize doesn't seem to respect the resized viewport completely in the sense that the image sometimes will still go outside of the viewport after resize

@tihuan
Copy link
Contributor Author

tihuan commented May 10, 2024

Ask Nik if this is mandatory or if re-center is fine

@tihuan
Copy link
Contributor Author

tihuan commented May 10, 2024

Nik and Seve both said that people don't resize window often, so lower this to a P1

@tihuan tihuan added P1 Priority 1 - Improvement with wide impact, fix within 1 week and removed P0 Priority 0 - Critical, fix ASAP! labels May 10, 2024
@tihuan tihuan added P2 Priority 2 - Improvement with narrower impact, fix within a month and removed P1 Priority 1 - Improvement with wide impact, fix within 1 week labels Jun 3, 2024
@tihuan
Copy link
Contributor Author

tihuan commented Jun 3, 2024

Decrease to p2 until users think otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend front-end issue P2 Priority 2 - Improvement with narrower impact, fix within a month
Projects
None yet
Development

No branches or pull requests

1 participant