Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD type file dilemma #899

Open
tihuan opened this issue Apr 25, 2024 · 1 comment
Open

OSD type file dilemma #899

tihuan opened this issue Apr 25, 2024 · 1 comment
Labels
frontend front-end issue P2 Priority 2 - Improvement with narrower impact, fix within a month

Comments

@tihuan
Copy link
Contributor

tihuan commented Apr 25, 2024

Context:

  1. OSD types file is for v3, which is misleading with v4 library sometimes -_-
  2. Brain storm: Should we use GPT to generate type file?
  3. Seems not a huge problem for our limited customization of OSD.. maybe kick the can for now but add a HUGE caveat, so people are aware of the type mismatch

DoD:

  1. Find out if there's an open issue for v4 types and link it to our code as comment
  2. Add code comment warning that type file is in v3, so people are aware that TS could throw false errors
@tihuan tihuan added frontend front-end issue P1 Priority 1 - Improvement with wide impact, fix within 1 week labels Apr 25, 2024
@tihuan tihuan added P2 Priority 2 - Improvement with narrower impact, fix within a month and removed P1 Priority 1 - Improvement with wide impact, fix within 1 week labels Jun 3, 2024
@tihuan
Copy link
Contributor Author

tihuan commented Jun 3, 2024

Decrease to p2, since I don't think we'll touch openseadragon frequently enough that the misleading type issue will have large enough impact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend front-end issue P2 Priority 2 - Improvement with narrower impact, fix within a month
Projects
None yet
Development

No branches or pull requests

1 participant