Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating drum with post-processing example is now useless #1003

Open
blaisb opened this issue Jan 28, 2024 · 4 comments
Open

Rotating drum with post-processing example is now useless #1003

blaisb opened this issue Jan 28, 2024 · 4 comments

Comments

@blaisb
Copy link
Contributor

blaisb commented Jan 28, 2024

We have an example (this one https://lethe-cfd.github.io/lethe/documentation/examples/dem/rotating-drum-with-postprocessing/rotating-drum-with-postprocessing.html) which is literally useless since it only adds a single line and does not add any new interpretation or animations. It should be deprecated and removed

@nick0413
Copy link

nick0413 commented Sep 8, 2024

On this issue, i have been trying to run the small rotating drum example but i get the following error.

An error occurred in line <700> of file </home/nick0413/Software/lethe/git/source/core/utilities.cc> in function int get_max_number_of_boundary_conditions(const string&) The violated condition was: max_number_of_boundary_conditions >= 0 Additional information: Your parameter file does not contain any indication for the number of boundary conditions for any physics supported by Lethe. Since November 2023, Lethe requires that a "boundary conditions" subsection is present with at least "number=0"

Im thinking the entire example is outdated

@blaisb
Copy link
Contributor Author

blaisb commented Sep 8, 2024

Have you updated to the latest version of lethe? The parameter file for this example works fine with the current version ( I am running the example right now on my desktop computer)

@nick0413
Copy link

nick0413 commented Sep 8, 2024 via email

@blaisb
Copy link
Contributor Author

blaisb commented Sep 9, 2024

Well yes, the version you installed on WSL from last Monday should indeed be the latest version (at least nothing major should have changed since then).

The error you are specifying occurs at this line: https://github.com/chaos-polymtl/lethe/blob/master/examples/dem/3d-rotating-drum-postprocessing/rotating-drum-with-postprocessing.prm#L90

This is because at one point we did not specify the number of boundary conditions.

If that line is indeed correct, it would appear that something is being "read" differently between your prm files due to it running in WSL.

Generally, which is not such a good thing, but this boundary error is sometimes thrown when there is an illegal character in the file since it is always the first "command" that is run in the parameter files.
If you are using the version of the parameter file from the repo and you get this error, please post again here and I will try to tifgure this out with you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants