Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagrangian post-processing should be renamed. #1176

Open
OGaboriault opened this issue Jun 20, 2024 · 1 comment
Open

Lagrangian post-processing should be renamed. #1176

OGaboriault opened this issue Jun 20, 2024 · 1 comment
Assignees

Comments

@OGaboriault
Copy link
Collaborator

OGaboriault commented Jun 20, 2024

In the parameter file, it is the only parameter starting with a capital letter. Also, the output file it is generating should be renamed since we have two post-processing tool now. (Force chains and this)

@OGaboriault OGaboriault self-assigned this Jun 20, 2024
@acdaigneault
Copy link
Collaborator

acdaigneault commented Jul 19, 2024

Renaming the output files for the post processing may makes some post-processing code in examples not compatible.
I do not see the issue since the force chain feature has its own output name and the "postprocess_data" name seems ok to discribe the "almost" raw data. I mean, this is mostly averaged values by cell (velocities, granular temperature) or output of data (subdomain, mobility status).
Do you have suggestion about new names?
I agree with the tiny annoying capital letter tho x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants