Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[task] Create a new task that autorefreshes identities periodically #599

Merged
merged 2 commits into from
Oct 19, 2023
Merged

[task] Create a new task that autorefreshes identities periodically #599

merged 2 commits into from
Oct 19, 2023

Conversation

jjmerchante
Copy link
Contributor

Create a new Global task that runs an autorefresh process for all the backends continuously. The period this Task is executed depends on the configuration defined by sortinghat.sleep_for.

@jjmerchante
[task] Create a new task that autorefresh identities periodically
102d6ab 
Create a new Global task that run autorefresh process for all the
backends continously. The time at which this Task is executed depends
on the configuration defined at 'sortinghat.sleep_for'.

Signed-off-by: Jose Javier Merchante <[email protected]>
@jjmerchante
Set enrich parameters with keyword argument
f11fbcc 
This commit includes the keyword argument for all the parameters
when initializing an enrich backend to avoid issues.

Signed-off-by: Jose Javier Merchante <[email protected]>
@jjmerchante jjmerchante marked this pull request as ready for review October 18, 2023 10:22
@coveralls
Copy link

coveralls commented Oct 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6559508776

  • 48 of 80 (60.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 71.03%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sirmordred/sirmordred.py 1 2 50.0%
sirmordred/task_enrich.py 0 4 0.0%
sirmordred/task_autorefresh.py 43 70 61.43%
Files with Coverage Reduction New Missed Lines %
sirmordred/sirmordred.py 3 21.74%
Totals Coverage Status
Change from base Build 6483840862: -0.8%
Covered Lines: 814
Relevant Lines: 1146
💛 - Coveralls

sduenas
sduenas approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit 90ad318 into chaoss:master Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduenas sduenas sduenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjmerchante @coveralls @sduenas