Include days spent in collection phase logs #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
reviewed
Jul 30, 2024
sirmordred/task_collection.py
Outdated
| @@ -74,7 +75,7 @@ def execute(self): | |||
| logging.info('%s collect disabled', self.backend_section) | |||
| return errors | |||
|
|
|||
| t2 = time.time() | |||
| time_start = datetime.now() | |||
There was a problem hiding this comment.
Shouldn't be better to use the datetime_utcnow() from grimoirelab_toolkit?
There was a problem hiding this comment.
The enrichment was using datetime.datetime.now() to calculate the spent time, that's why I used the same. I updated it to use datetime_utcnow(), should I update the enrichment to use datetime_utcnow()?
When the collection phase is finished and the spent time is more than one day, days are missing in the logs. It is now fixed and included in the logs. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
collection-spent-time
branch
from
3a0ff9b to
f5a2602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the collection phase is finished and the spent time is more than one day, days are missing in the logs. It is now fixed and included in the logs.