Empty "merged" fields in github2_pull_request index

[canasdiaz]

The github2_pull_request index (which an alias) is not coherent, so it is not possible to show all the data for pull requests. As an example, the following fields are not filled for all the documents:

• pull_merged
• pull_merged_at

So, when using the index, it is not possible to show all the comments (both general and line comments) for merged pull requests. Find below an example of the analysis of this pull request

This behavior has been seen in grimoirelab/grimoirelab:0.7.1

[zhquan]

@canasdiaz the alias github2_pull_request contains two indexes github2_issue (with filter issue_pull_request: true) and github2_pull_request. So only the comment from github2_pull_request will have the pull_merged_at field.

We need both of them because for GitHub only a review comment is a pull request comment but a simple comment is an issue comment even if it is in a pull request (remember that for GitHub a pull request is also an issue).

[canasdiaz]

I understand what you say about the API. We should not forward the issues we have with the API to the customers. This is a wrong design decision, and it adds an unwanted limitation to the data analysis.