Add grid size to the verbose GPU output #26153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
e-kayrakli
changed the title
DanilaFe
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the grid size to the kernel launch output when verbose GPU mode is used.
Resolves #25980
While there, it also adds a proper runtime error for when a non-positive block size is specified by the user. Without it, I am getting floating point exceptions for 0 block size. It'll probably be an error message from the driver if you specify something negative.
Test: