Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: grepcomp should check all dyno locations, too #26278

Open
lydia-duncan opened this issue Nov 20, 2024 · 4 comments
Open

[Feature Request]: grepcomp should check all dyno locations, too #26278

lydia-duncan opened this issue Nov 20, 2024 · 4 comments

Comments

@lydia-duncan
Copy link
Member

Summary of Feature

Description:
This keeps bugging me so I figured I should file an issue. When making compiler changes, I really appreciate being able to use grepcomp instead of having to write a normal grep. But since we started developing dyno and putting some of its code in frontend, a grepcomp does not return all compiler results. We should update grepcomp to search all compiler-related locations, not just things related to the old compiler.

I suspect grepmake and grepdoc could also use an update to make sure they're still as useful as we'd like.

Is this issue currently blocking your progress?
no, it's just annoying

Code Sample

$ grepcomp ExprParenth
@lydia-duncan
Copy link
Member Author

This is probably not too hard to do, so I may get around to it the next time it bugs me. I'm just not the most confident on script changes, so have been putting it off out of fear XD

@lydia-duncan
Copy link
Member Author

I think grepcomp should also be updated to search locations used for chpldoc, the language server, anything that relies on compiler code

@mppf
Copy link
Member

mppf commented Dec 2, 2024

Might be nonsense, but: a grepcomp could be interpreted as "grep the compiler/ directory" which would not include these other locations. Under that interpretation, it might be confusing to have it search frontend/.

It's not particularly important to me that grepcomp work any way at all. I'm more bringing this up to say that 1) we should consider changing the name and 2) we should absolutely put a comment at the top of the script (and/or other help materials) that communicates its purpose.

@lydia-duncan
Copy link
Member Author

I'm more bringing this up to say that 1) we should consider changing the name and 2) we should absolutely put a comment at the top of the script (and/or other help materials) that communicates its purpose.

I think those are both reasonable suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants